Giter VIP home page Giter VIP logo

Comments (4)

frangio avatar frangio commented on August 16, 2024 2

Let's remove the part about access control. I don't think a "royalty setter" role is the way this will be used in general.

Populating those fields would inherit from the tokenRoyalty contract and call the setDefaultRoyalty from the constructor.

This should be enough to get started.

from contracts-wizard.

SudarminThen avatar SudarminThen commented on August 16, 2024 1

Would like to see this to be implemented too, will this be implemented in the future?

from contracts-wizard.

frangio avatar frangio commented on August 16, 2024 1

That's awesome @gmertk! Feel free to open a Draft PR any time and we can begin reviewing. It's not going to be merged until royalties are released in OpenZeppelin Contracts later this month.

from contracts-wizard.

gmertk avatar gmertk commented on August 16, 2024

Hello,

I was just looking into this project today.

I have a diff for this on gmertk@29d903e

If it is ok for you, I can send a pull request after OpenZeppelin/openzeppelin-contracts#3012 is merged.

Cheers!

from contracts-wizard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.