Comments (3)
frangio
commented on August 16, 2024
1
Your observation is correct about constant variables in general, but keccak256 of string literals is treated specially and the hash is evaluated at compile time. It's not even necessary to have optimizations enabled. You can see this in the changelog items for 0.6.12, and I've just confirmed that this is the way it works currently.
immutable may result in cheaper deployment costs because the hash doesn't have to be included in the bytecode... But this is something we'd have to confirm through benchmarks.
from contracts-wizard.
pcaversaccio
commented on August 16, 2024
Yeah, you are right - thanks for the clarification. For the sake of completeness, there is however a general issue that is still open: ethereum/solidity#3157.
from contracts-wizard.
pcaversaccio
commented on August 16, 2024
@frangio your _PERMIT_TYPEHASH variable is however declared as immutable here. Is there a specific reason? Otherwise, I would propose to make this constant as well due to the sake of consistency (happy to make a PR).
from contracts-wizard.
Related Issues (20)
- Can't resolve '../openzeppelin-contracts' in `wizard` 0.2.2 HOT 2
- ERC20 Premint field has no upper bound
- Invalid contracts generated for @openzeppelin/contracts 4.9.0 HOT 1
- Use package entry points for core
- Enable ERC20Permit by default HOT 7
- Use token-specific pausable extensions HOT 1
- add required OpenZeppelin Contracts version as a comment ? HOT 1
- Copy to Clipboard not working from docs site HOT 1
- Use Cairo specific highlighting for Cairo 1+
- Provide better feedback in UI when input is invalid
- Add Cairo lang and OZ Contracts versions to generated contracts HOT 4
- [Vanta] Remediate "Low vulnerabilities identified in packages are addressed (Github Repo)" for npm-undici/CVE-2024-24758 HOT 1
- [Vanta] Remediate "Low vulnerabilities identified in packages are addressed (Github Repo)" for npm-undici/CVE-2024-24758 HOT 1
- [Vanta] Remediate "Low vulnerabilities identified in packages are addressed (Github Repo)" for npm-undici/CVE-2024-24758 HOT 1
- Support mixins
- Consider making upgradeability opt out HOT 2
- Support older version of the contracts library. HOT 1
- Support Contracts for Cairo v0.10.0
- Use Hardhat Ignition in downloaded Hardhat development package
- Used named imports for Solidity HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contracts-wizard.