Comments (3)
@rickr, Would you mind taking a look at tskuse@3c1b456 ?
Enabling Express trust proxy
:
(Recommend reviewing config options: http://expressjs.com/en/guide/behind-proxies.html. I'm not fully aware of the serving arrangement.)
Although the app will not fail to run if the application variable trust proxy is not set, it will incorrectly register the proxy’s IP address as the client IP address unless trust proxy is configured.
Setting a non-false trust proxy value results in three important changes:
The value of req.hostname is derived from the value set in the X-Forwarded-Host header, which can be set by the client or by the proxy.
X-Forwarded-Proto can be set by the reverse proxy to tell the app whether it is https or http or even an invalid name. This value is reflected by req.protocol.
The req.ip and req.ips values are populated with the list of addresses from X-Forwarded-For.
from operationcode_frontend.
That looks like a sane change. We can merge it in and test it out in prod before we launch this week.
from operationcode_frontend.
Fixed in #95
from operationcode_frontend.
Related Issues (20)
- Add CivicX image to press page HOT 6
- Add media highlights to Operation Code website: Boston HOT 2
- Add media highlights to Operation Code website: NYC HOT 2
- Add media highlights to Operation Code website: General HOT 2
- Fix misspelling on history page for Techstars HOT 7
- Remove implementations of ID.me verification from front-end
- Feature: modernize bug/ suggestion form pipeline HOT 4
- Add 1password to Partners HOT 1
- Redirect Mentor Request link to internal app route
- Mentor Request form should show loading spinner after submit
- Allow frontend to accept different URLs HOT 8
- move vettec to primary frontend HOT 16
- On team page, add a separate category for volunteers HOT 2
- Remove DoD Seals from website
- Feature: Mentor form modifications HOT 1
- 404 page is being indexed by search engines HOT 14
- App asked me for more info but is not saving my selected option on dropdown box HOT 2
- Change Partners to Sponsors
- BUG: Code school url is incorrect HOT 4
- Remove Mentor request link, and add information for slack mentor request.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from operationcode_frontend.