Giter VIP home page Giter VIP logo

Comments (6)

fanminshi avatar fanminshi commented on May 9, 2024

Thanks @baichinger for pointing this out.

from operator-sdk.

fanminshi avatar fanminshi commented on May 9, 2024

The #184 is kinda related to this one. I think the placement of the scripts and dockerfile under tmp/ dir might not be the best idea. The first, it doesn't allow user to modify the scripts to fit for their need. The second, the tmp/ naming is not intuitive.

cc/ @spahl @hasbro17

from operator-sdk.

spahl avatar spahl commented on May 9, 2024

I agree. We need to have one place for the autogenerated things that no one should change (not named tmp/ but something even more explicit) and then allow to extend those (like for example using two dockerfiles that build on each other)

from operator-sdk.

spahl avatar spahl commented on May 9, 2024

Note: if done right there is no reason for the tmp folder to exist.

from operator-sdk.

dmage avatar dmage commented on May 9, 2024

that no one should change

In theory yes, but in our operator we've changed it to fill the Version field based on the git data (-ldflags "-X github.com/my/package/version.Version=$(git describe)").

from operator-sdk.

shawn-hurley avatar shawn-hurley commented on May 9, 2024

Closed by #615

from operator-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.