Giter VIP home page Giter VIP logo

Comments (8)

bska avatar bska commented on July 19, 2024

I don't think we should merge this branch until we know if it fixes issue #113 automatically or how much work it will be to fix that issue in the context of CMake. We absolutely cannot ship a release until #113 is corrected.

from opm-core.

totto82 avatar totto82 commented on July 19, 2024

It seems opm-core is build correctly know (see #113).

Are the tutorials supposed to be build automatically in the CMake branch as they did in Master? For the moment they don't.

I tried to build them manually (using g++), but I struggle to link them to OPM. Most probably the reason is lack of competence in c++. Any hints?

from opm-core.

atgeirr avatar atgeirr commented on July 19, 2024

I understand that this task is getting closer to merging. It is my opinion that we need a (possibly short) transition period in which both autotools and cmake can be used, both systems living on the same, single branch. After comparison testing we can then drop autotools.

Is this what you are preparing, @rolk?

from opm-core.

kristinf avatar kristinf commented on July 19, 2024

I have problems linking the opm-core correctly when I have built the cmake branch. I followed your steps from the OPM mailinglist posted today and downloaded the dune modules, opm-core and dune-cornerpoint. With dunecontrol it does not find opm-core when building dune-cornerpoint even though the opm-core cmake branch was built and installed correctly. I have no problems building everything with autotools for the opm-core master branch.

from opm-core.

rolk avatar rolk commented on July 19, 2024

@kristinf
Please post opm-core/CMakeFIles/CMake*.log and dune-cornerpoint/config.log in issue #137

from opm-core.

blattms avatar blattms commented on July 19, 2024

On Fri, Feb 01, 2013 at 07:41:42AM -0800, Kristin Flornes wrote:

I have problems linking the opm-core correctly when I have built the cmake branch. I followed your steps from the OPM mailinglist posted today and downloaded the dune modules, opm-core and dune-cornerpoint. With dunecontrol it does not find opm-core when building dune-cornerpoint even though the opm-core cmake branch was built and installed correctly. I have no problems building everything with autotools for the opm-core master branch.

I remember that we has similar problems with the DUNE cmake
branches. On my system everything worked fine, but e.g. Christoph had
problems with missing symbols. It turned out that my CMake version did
build the libraries in a way such that libraries that it depended on
where either incorporate (static linking) or link information was put
in the library. For some CMake version this was not the case and we
ended up with providing all necessary libraries to the linker.

Could be the problem here, if opm-core depends on some libraries that
are missing in the test for it.

from opm-core.

rolk avatar rolk commented on July 19, 2024

@blattms

CMake built the libraries in a way such that libraries that it depended on where either incorporate (static linking) or
link information was put in the library. For some versions this was not the case

That is certainly an interesting lead that we'll be looking into. Your intuition have been amazingly correct before :-)

from opm-core.

rolk avatar rolk commented on July 19, 2024

The cmake branch has now been merged with master in the branch release/2013.03 (which at a later stage will be merged into master)

from opm-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.