Comments (7)
On Tue, Mar 19, 2013 at 04:56:31PM -0700, Roland Kaufmann wrote:
An improvement to this would be to include the config mode files
ourselves to first gather more information about where the source
tree is located. The PkgConfig files cannot be used, as they point
to the intended install location of the library instead of the
build tree.
There are two package config files: one in ${PROJECT_BINARY_DIR} and one
in ${PROJECT_BINARY_DIR}/cmake/pkg/. Only the latter is meant for
installation. The previous contains the definitions for using the
module uninstalled.
BTW: I did not have any problems using the DUNE's cmake modules as
dunecontrol is smart enough to use the correct location for
-D<dune_module>_DIR and OPM seems to find them with its find_package
call. Regarding the definitions this should be same picture as for the
DUNE modules with auto-tools. In both cases OPM does not rely on the
provided build infrastructure but uses its own tests.
I admit that this is not the ideal case, but it should suffice for the
release. Later on, making OPM real DUNE cmake modules is probably
preferable.
from opm-core.
two package config files: one in ${PROJECT_BINARY_DIR} and one in ${PROJECT_BINARY_DIR}/cmake/pkg/. Only the latter is meant for installation. The previous contains the definitions for using the module uninstalled
Configured like this:
dune-common/bin/dunecontrol --builddir=build-autotools --configure-opts='--enable-shared' all
then run:
env PKG_CONFIG_PATH=dune-common/build-autotools/ pkg-config --cflags dune-common
yields -I/usr/local/include
.
This is r7427
from https://svn.dune-project.org/svn/dune-common/branches/release-cmake-2.2
from opm-core.
On Wed, Mar 20, 2013 at 07:11:53AM -0700, Roland Kaufmann wrote:
two package config files: one in ${PROJECT_BINARY_DIR} and one in ${PROJECT_BINARY_DIR}/cmake/pkg/. Only the latter is meant for installation. The previous contains the definitions for using the module uninstalled
env PKG_CONFIG_PATH=dune-common/build-autotools/ pkg-config --cflags dune-common
Actually I thought you were talking about CMake's package config files
(e.g. dune-common-config.cmake) and not about those of pkg-config. For
pkg-config you are correct of course.
This is not special to the cmake branches. It is the same for the
official version.
from opm-core.
Is this still an issue and, if so, is there something that can be done about it?
from opm-core.
Is this still an issue and, if so, is there something that can be done about it?
Yes, it is still an issue; no, we don't have to do anything because it works as it is now; yes, we can do something about it; but no, no-one wants to spend time on it. So, in conclusion, if you want to clear out the issue list before the release, this should probably just be closed as won't-fix.
from opm-core.
if you want to clear out the issue list before the release, this should probably just be closed as won't-fix.
I'm not particularly hell-bent on clearing the list, but I do want to understand/know the status of most of the issues. A "won't-fix" could be the best solution, but I'll leave it open for now. Thanks for the update!
from opm-core.
I'll close this as won't fix since we quite clearly do not have to fix this and will not spend any effort on it.
from opm-core.
Related Issues (20)
- Some tests break after OPM/opm-parser#768 HOT 1
- Initialization and restart HOT 1
- Failing test_relpermdiagnostics HOT 4
- Dereferencing of end iterator happens in initStateEquil.hpp
- test_pinchprocessor is broken? HOT 3
- opm-core build fails HOT 4
- parameter's ouput does not show up in .CASE_NAME.DEBUG HOT 2
- Allow passing the size of the initial time step to adaptive time stepper HOT 1
- Runtime failure in "linsolver" test - umfpack not configured HOT 2
- Add restart test with no wells present.
- WellState::init has memory problems HOT 7
- Don't we need to keep track of (artificially) shut completions in the simulator for output? HOT 3
- Windows Installer (guide) failed HOT 3
- Compilation error due to not finding opm/output/data/Wells.hpp HOT 2
- Broken test HOT 3
- Multiple definitions of OPM_THROW HOT 1
- opm-core broken related to petsc HOT 2
- Some files missing? HOT 2
- Question: How OPM handles well sources in multi-cell wells? HOT 4
- Installing OPM in CentOS 8.1 (RPM) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opm-core.