Giter VIP home page Giter VIP logo

Comments (5)

bska avatar bska commented on July 19, 2024

std::tr1::array as the return type

You're right. That's been a http://www.youtube.com/watch?v=_AmkmqYEarw for quite some time. Not only is it ugly and non-portable, there might not even be a std::tr1 namespace even for those compilers that do implement the TR1.

I propose to use boost::array instead

I concur. There are also a few uses of std::tr1::shared_ptr<> for which boost::shared_ptr<> ought to be a drop-in replacement.

from opm-core.

blattms avatar blattms commented on July 19, 2024

I tried to clean this up in the following pull requests: #274 OPM/opm-porsol#58 OPM/opm-upscaling#67 OPM/opm-grid#35

from opm-core.

bska avatar bska commented on July 19, 2024

I tried to clean this up in the following pull requests

Great! I'll just do a minimal build test before I merge, but everything appears to be fine.

from opm-core.

bska avatar bska commented on July 19, 2024

The requests in question (#274 OPM/opm-porsol#58 OPM/opm-upscaling#67 OPM/opm-grid#35) have all been merged into their respective master branches. I take it this issue can be closed?

from opm-core.

bska avatar bska commented on July 19, 2024

I'm preemptively closing this issue as there has been no real activity in a month and the PRs that corrected the code were merged long ago. Please reopen if the issue resurfaces.

from opm-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.