Comments (9)
use the original relperm upscaling code
Just out of curiosity, do you have an idea of what time point corresponds to the original relperm upscaling code? I.e., whether it was based on sources from one year ago, three years ago, five years ago or ten years ago?
from opm-upscaling.
We can double check tomorrow, but I believe we went back to the sang based code to get a reference solution.
from opm-upscaling.
Just checked. We seem to have incorrect results all the way back to May 2012. Louis can send you a test case.
from opm-upscaling.
We seem to have incorrect results all the way back to May 2012.
Okay, that does at least narrow the search region a bit.
Louis can send you a test case.
Yes please.
from opm-upscaling.
There's a wonderful dichotomy in the discretisation of the gravity term in the upscale_relperm
utility (and maybe others, I haven't verified this). While the grid constructor assumes that all lengths and depths are given in units of metres the gravity term discretisation assumes that the depths are given in units of centimetres.
I think I know the historical reason for this assumption. All of the models used in the original development of the upscaling utility used centimetre length scales. Would you mind, as a quick check/hack, to run the tests using
-gravity 981
rather than 9.81
and see if you get better results this way?
from opm-upscaling.
Today I finally had occasion to look into this more closely. My preliminary conclusion is that the gravity handling is fundamentally broken (not to mention, explicitly turned off in the low-level upscaling code, despite being actively queried in upscale_relperm.cpp
).
Moreover, some parts of the code assume centi-metre length scales, while others use metres. That, in turn, affects pressure gradients and flow rates--at least when the flow is driven by pressure drops.
Fixing this will require days of implementation work--not to mention substantial testing efforts--and will affect code in other OPM modules.
from opm-upscaling.
I have finished my initial implementation of this feature so I'd like to enlist some testing help to assess the state of completion. At this time I'm a little reluctant to create a PR because there may still be a lot of work remaining depending on the testing outcome. Therefore, if you would like to help test, please use the following commands to access my branch
git checkout -b bska_capillary-gravity-upscaling
git pull git://github.com/bska/opm-upscaling.git capillary-gravity-upscaling
from opm-upscaling.
Excellent! I can confirm that the branch builds (when merged on top of master, to account for the opm-parser API change). There is a test failure:
14/16 Test #14: upscale_relperm_BCf_pts30_surfTens11_stoneAniso_stoneAniso_27cellsAniso ............................***Failed 0.18 sec
This is expected since this test essentially is a regression test, and the fixed bugs should be expected to change the results for some of the tests.
from opm-upscaling.
This was fixed a year ago, closing.
from opm-upscaling.
Related Issues (20)
- Possible bug in in/out flow - side_flux hidden multiplication
- Build errors HOT 2
- Build error: Opm::EclipseGridInspector::EclipseGridInspector HOT 3
- Opm-material PR #138 breaks opm-upscaling build HOT 6
- ctest failure: compareUpscaling.cpp: Could not open file. HOT 6
- Property Upscaling With Linear Pressure Drops Effectively Requires Shoe-Box Geometries HOT 6
- cpchop error: segmentation fault? HOT 6
- Upscaling Absolute Permeability HOT 1
- Unable to build the module on MacOS-Catelina HOT 6
- Utilization of PETSc solvers HOT 3
- slight build problem in FreeBSD-12.1, with clang-8.0.1 HOT 1
- fix for /bin/sh script
- Add manpages for binaries HOT 6
- Official Debian Packages HOT 1
- Update manpages HOT 2
- "Malformed floating point number" while reading GRDECL file HOT 2
- Relative Permeability Upscaling w/ Two-Phase Simulation?
- steadystate_test_implicit is missing documentation (manpage et al) HOT 4
- std::binary_function is deprecated since g++12 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opm-upscaling.