Improve OptimizelyConfig instantiation performance about javascript-sdk HOT 12 CLOSED

Hi @alexZielonko - thanks for bringing up this enhancement proposal, love the formatting and I agree that we should be consolidating redundant iterations.

Will chat with the team on this to set up a time to double check that the enhancement proposed looks good; will follow up here afterwards. Thanks!

from javascript-sdk.

Hi @alexZielonko , you can find this performance enhancements in Release 4.9.4! We appreciate your collaboration on the change.

I'll go ahead and close this. Please let us know if any questions or concerns.

from javascript-sdk.

@alexZielonko - hey! Sorry for the lack of communication; the team's been busy prepping for a major version update of the JS SDK. We're planning on diving into this issue after v5.0.0 releases so will provide an update after the dust settles there. Unfortunately, cannot provide an exact ETA at this time, though I can say that we are looking for a v5.0.0-beta release within the next week or so.

If you need the changes sooner, however, I would recommend forking this repository, base a branch off of v4.9.3, and manually apply your suggested changes there. If you have any further Qs, feel free to drop them below - thanks for your patience!

from javascript-sdk.

Hello @russell-loube-optimizely thank you for the update. I'm looking forward to this performance enhancement and will keep an eye on the pull request.

from javascript-sdk.

@russell-loube-optimizely I reviewed your team's PR and noticed another potential performance enhancement. Please encourage them to consider the suggestion proposed in this comment, #828 (comment).

from javascript-sdk.

Hey @alexZielonko , thanks for reviewing and partnering with us on this. I see @raju-opti responded and agrees it's a sensible change.

I'll be in touch in the near future r/e delivery timelines.

from javascript-sdk.

Thank you @opti-jnguyen if it works this fix should help a lot with performance!

from javascript-sdk.

hello @opti-jnguyen! I really appreciate you looking into this. Are there any updates from your team's end?

from javascript-sdk.

@opti-jnguyen Thank you for following up with this additional information. I am disappointed to learn that you're unable to prioritize customer impacting performance issues in your SDK.

Maintaining a separate fork of vendor software isn't a pragmatic technical decision, and it inadequately resolves this issue.

Please keep me informed of any prioritization updates, as I am eager to see these improvements incorporated into the SDK.

from javascript-sdk.

Hi @alexZielonko , I wanted to provide an update. One of our engineers has evaluated your proposed solutions. Both are technically viable and would achieve desired performance improvements. I'd like to discuss with our team this week to pick an implementation approach.

I'll respond here with any timeline updates once we size this effort and get started in earnest. Thank you.

from javascript-sdk.

Hi again @alexZielonko , quick update - we have a PR open to implement the first option you shared with us currently in code review.

from javascript-sdk.

Thank you @russell-loube-optimizely, I appreciate your team's support!

from javascript-sdk.