Giter VIP home page Giter VIP logo

Comments (5)

chrisseaton avatar chrisseaton commented on July 29, 2024

Is this with your patch applied?

It looks like the issue may be an incompatible Truffle and Graal version. Can you give me the commits you are using of Truffle, Graal and TruffleRuby? The commits that end up being the current one in practice at the end of your build in each of those repos, rather than those which you intend to use.

They should be:

  • Truffle: 8ee22e950e033dada680381ed9e02b0225360110
  • Graal: 1236bbd1691733995623f3f42f9ac3984300e437
  • TruffleRuby: 6e9d5d3817773057e3c155e74140651b9be29bc7 (+ your patch I presume)

from truffleruby.

vext01 avatar vext01 commented on July 29, 2024

Hi Chris,

Yes, this is with our patch, but I don't think it's related to that (I hope).

It seems that, indeed, there are version discrepancies. I have:

  • Truffle: ca92fe9778c9dfefef63ae4ebe01c6ccb78adc18 <-- this is wrong.
  • Graal: 1236bbd1691733995623f3f42f9ac3984300e437
  • TruffleRuby: 6e9d5d3817773057e3c155e74140651b9be29bc7

Truffle is automatically fetch by mx. So either we have an mx bug, or I'm using it wrong.

Perhaps you could review my build steps and see if I'm doing something wrong. Must admit, I don't really understand mx. Perhaps I can just checkout the right truffle tag once mx fetched it?

Here's how I build a JVMCI enabled JVM:
https://github.com/softdevteam/warmup_experiment/blob/update-vms-2017/build.sh#L495

And here's the TruffleRuby part:
https://github.com/softdevteam/warmup_experiment/blob/update-vms-2017/build.sh#L578

from truffleruby.

vext01 avatar vext01 commented on July 29, 2024

If I try forcing the truffle version to graalvm-0.22 (to match the hash you posted above), I get the same error...

I'm not sure I can simply check out a tag like that. I'm probably short-circuiting some stuff mx is supposed to take care of...

from truffleruby.

chrisseaton avatar chrisseaton commented on July 29, 2024

We're mixing Maven and mx here. mx doesn't get a chance to specify the Truffle version that Ruby builds with. Try this:

diff --git a/mx.truffleruby/suite.py b/mx.truffleruby/suite.py
index 77f9daf..b782115 100644
--- a/mx.truffleruby/suite.py
+++ b/mx.truffleruby/suite.py
@@ -15,7 +15,7 @@ suite = {
             {
                 "name": "truffle",
                 # Must be the same as in truffle/pom.xml (except for the -SNAPSHOT part only in pom.xml, and there we can use a release name)
-                "version": "c02973969fb144b533ae0e53187674cb04c2aacc",
+                "version": "8ee22e950e033dada680381ed9e02b0225360110",
                 "urls": [
                     {"url": "https://github.com/graalvm/truffle.git", "kind": "git"},
                     {"url": "https://curio.ssw.jku.at/nexus/content/repositories/snapshots", "kind": "binary"},
diff --git a/truffleruby/pom.xml b/truffleruby/pom.xml
index bbd7871..7ef82d1 100644
--- a/truffleruby/pom.xml
+++ b/truffleruby/pom.xml
@@ -11,7 +11,7 @@
   <properties>
     <maven.test.skip>true</maven.test.skip>
     <!-- Must be the same as in mx.truffleruby/suite.py (except for the -SNAPSHOT part, and here we can use a release name) -->
-    <truffle.version>c02973969fb144b533ae0e53187674cb04c2aacc-SNAPSHOT</truffle.version>
+    <truffle.version>8ee22e950e033dada680381ed9e02b0225360110-SNAPSHOT</truffle.version>
   </properties>
   <repositories>
     <repository>

from truffleruby.

vext01 avatar vext01 commented on July 29, 2024

Thanks for your help with this chris.

from truffleruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.