Giter VIP home page Giter VIP logo

Comments (9)

 avatar commented on June 16, 2024 1

Merged!

from a11y-guidelines.

Aniort avatar Aniort commented on June 16, 2024

Or “explode” the abbr meaning for the first occurrence in the page
Perhaps in a guideline site, a glossary’ll be better ?! don't know...

from a11y-guidelines.

 avatar commented on June 16, 2024

Yes, expand first occurrence seems easier to set up, somehow.

Any other opinions?

from a11y-guidelines.

ffoodd avatar ffoodd commented on June 16, 2024

Both of them?

Expand the meaning of the first occurrence on any page (which is, as far as I know, the rule: have a look at the associated RGAA criteria) and add a glossary, common to the entire guidelines.

Glossary might help and interest some people, since it's a way to apprehend guidelines from a tech view and learn jargon quickly.

from a11y-guidelines.

 avatar commented on June 16, 2024

Assigning it to myself, will see to it later.

from a11y-guidelines.

 avatar commented on June 16, 2024

I created a new Branch: https://github.com/Orange-OpenSource/a11y-guidelines/tree/iss1

I had the choice between:

  1. linking to a new Glossary page
  2. expanding abbreviations on the spot.

I chose 2 as it was easier for a POC, we'll discuss it among us.

For debugging purposes, abbreviations and expanded texts are highlighted with an ugly colour 😉.

@Lausselloic and @SylvainBzh can you validate:

  1. Is the logic OK with you? Or would you like another behaviour?
  2. Is the code OK with you?

TODO (me, after Loic's and Sylvain's feedback):

  1. On Master: replace <abbr>HTML</abbr>5 with <abbr>HTML5</abbr>
  2. Finish French version
    • Remove debug line 210 "// REMOVE THIS BEFORE MERGING"
    • Full inventory of abbreviations
    • remove style='background:#99ffff' 😜
  3. English version
    • Copy the code in web_EN/theme/default/js/reco.js
    • Change Glossary to fit English version (span lang="fr" etc.)

from a11y-guidelines.

 avatar commented on June 16, 2024

After meeting this afternoon:

  • Glossary added to bottom of page
  • Each abbr is wrapped in an a that links to the proper entry in the glossary.

@PigeardSylvain weird thing though, the glossary dl looks out of #content. I looked into the CSS but didn't find what's wrong.

from a11y-guidelines.

PigeardSylvain avatar PigeardSylvain commented on June 16, 2024

TODO @sdeschamps-orange : add a title attribute on all abbr tag that does not already have one.

from a11y-guidelines.

 avatar commented on June 16, 2024

So? Merge iss1 with master and close this issue, anyone?

from a11y-guidelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.