Giter VIP home page Giter VIP logo

Comments (14)

pnorman avatar pnorman commented on July 22, 2024

So as a common repository for both project seems currently out of reach

Just to clarify - there are no technical barriers, and in fact I use this repo with JOSM.

from editor-layer-index.

bastik avatar bastik commented on July 22, 2024

So as a common repository for both project seems currently out of reach

Just to clarify - there are no technical barriers, and in fact I use this repo with JOSM.

Yes. The other way around would also work fine: It shouldn't be hard to write a xml -> json converter, if it doesn't exist already. The issue is not so much the output, but more different philosophies in how to allow user input and "not invented here" syndrome, see #67 for an earlier discussion.

As I have not much hope for a resolution in the near future, I suggest this more modest goal, which would also be a necessary intermediate step towards unification.

from editor-layer-index.

Skippern avatar Skippern commented on July 22, 2024

I sort of agree with @bastik though would prefere if JOSM actually adopts this. Currently I do as @pnorman and load this repo into JOSM.

If somebody are willing to take the time and add the outstanding sources from JOSM into this repo, and maintaining it as up-to-date as possible, i.e. re-running every x weeks, than it might be easier to sell this in with JOSM developers.

Also maybe it is time to look at dead-link/layer-health-check, and flag dead or unhealthy entries. One could also have an experimental OpenLayer where each layer could be health-checked in a web browser. There are many things we can do to make this an easier sell to JOSM dev.

from editor-layer-index.

iandees avatar iandees commented on July 22, 2024

Those are all great suggestions for pull requests. If someone were to write a dead-link check there are plenty of places to run it. Also, we have a good start at a frontend for this listing at http://osmlab.github.io/editor-imagery-index/. It would be great to have someone add a slippy-map interface to that.

from editor-layer-index.

bhousel avatar bhousel commented on July 22, 2024

Closing as there is nothing actionable here. Please open individual issues or pull requests for any sources that are missing from this repository.

from editor-layer-index.

Klumbumbus avatar Klumbumbus commented on July 22, 2024

Here is an update on the current sync state between the JOSM and ELI databases.
The output of the comparison script is here: https://josm.openstreetmap.de/wiki/ImageryCompare (There is also written what is compared and what not).

The JOSM database was synced recently. There are 166 entries, which are in JOSM but not in ELI (the blue entries). JOSM has about 30 mirror entries (e.g. WMS and TMS for the same source). So for some of the 166 cases there is maybe already the TMS in ELI.

I checked all these 166 entries in the last 2 weeks if they still deliver tiles and they do (with a few exceptions, which are discussed at https://josm.openstreetmap.de/ticket/14086). So this would be a good moment to add them to the ELI database. (I personally don't plan to do this.)

from editor-layer-index.

simonpoole avatar simonpoole commented on July 22, 2024

@Klumbumbus I had a look at the blue entries I know something about, there are some duplicates, some stuff that is actually missing, and there are quite a few that have been removed from the ELI because they are of no practical use anymore. Now I can see that you could make an argument that you now and then might want to refer back to historic imagery, however that would seem to be somewhat at odds with presenting a user with a not overwhelming list of layers that they can reasonably use at the current time.

A simple solution would be to have a "historic" flag for such imagery, the not so simple would be something like a supersedes=xxxx attribute that would provide linkage between sources covering the same areas (or likely a combination of both).

from editor-layer-index.

Klumbumbus avatar Klumbumbus commented on July 22, 2024

One more update. The script was enhanced to compare icons and shapes.
There are 9 entries with missing shape, 19 entries where there is only a rectangle, but a more detailed shape is available in JOSM and 10 entries with outdated shapes. So in total 38 entries, which can be updated in ELI.

(I'll fix/add the 26 icons but not the shapes.)

from editor-layer-index.

Klumbumbus avatar Klumbumbus commented on July 22, 2024

This is an invitation again to update and enhance the ELI database.

The JOSM comparison script has grown up to more than 900 lines of code. It compares now basically everything comparable, see the output. All the blue and yellow entries there should be fixed in ELI.

The script output is integrated into the JOSM continuous integration system, so new differences of both imagery databases are reported there. The test runs every 6 hours.

To ease copy and paste from JOSM to ELI there is now also an geojson output of the josm database. It can be found here (condensed version) and here (readable version for copy-paste). As the geojson output is not much tested please report if there are any problems.

from editor-layer-index.

pnorman avatar pnorman commented on July 22, 2024

The JOSM comparison script has grown up to more than 900 lines of code. It compares now basically everything comparable, see the output. All the blue and yellow entries there should be fixed in ELI.

Given that JOSM has improved its imagery XML editing so it works reasonably well, I wonder if it now makes sense to make ELI pull the JOSM XML and convert it to its existing formats. This probably needs discussion in its own issue.

from editor-layer-index.

simonpoole avatar simonpoole commented on July 22, 2024

A late note on this, straight from the horses (RMS) mouth: "but GPL version 3 does not permit relicensing to CC-BY-SA" with other words we shouldn't be using JOSM configuration for anything in ELI (the other way around is fine .....).

Not that the choice of CC BY-SA is free from problems.

from editor-layer-index.

pnorman avatar pnorman commented on July 22, 2024

Did JOSM change their wiki license?

from editor-layer-index.

simonpoole avatar simonpoole commented on July 22, 2024

AH I found it, but no wonder I couldn't find it, it is essentially invisible (right at the bottom of the page in light light grey).

from editor-layer-index.

Klumbumbus avatar Klumbumbus commented on July 22, 2024

The 2 licenses are also written at the bottom of the front page above the heading contact in dark dark black ;)

from editor-layer-index.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.