Hello Clover DB team, I've encountered an issue while integrating Cl

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

doc.Unmarshal does not play well with `json` tag about clover HOT 5 CLOSED

semolex commented on June 28, 2024

doc.Unmarshal does not play well with `json` tag

from clover.

Comments (5)

univac490 commented on June 28, 2024 1

actually, the json tag should be always be checked, not just when the clover tag is found.

from clover.

ostafen commented on June 28, 2024 1

@semolex: thank you for reporting the issue.

@univac490: could you submit a PR?

from clover.

ostafen commented on June 28, 2024 1

@semolex: please check if still have the issue.
@univac490: thank you very much for fix :=)

from clover.

univac490 commented on June 28, 2024

I made a local copy of clover/internal/encoding.go and updated createRenameMap as follows:

func createRenameMap(rv reflect.Value) map[string]string {
	renameMap := make(map[string]string)
	for i := 0; i < rv.NumField(); i++ {
		fieldType := rv.Type().Field(i)

		tagStr, found := fieldType.Tag.Lookup("clover")
		if found {
			name, _ := processStructTag(tagStr)
			jsonTagStr, found := fieldType.Tag.Lookup("json")
			if found {
				jsonName, _ := processStructTag(jsonTagStr)
				if jsonName != name {
					renameMap[name] = jsonName
				}
			} else {
				renameMap[name] = fieldType.Name
			}
		}
	}
	return renameMap
}

from clover.

semolex commented on June 28, 2024

@ostafen Thanks. Confirmed. Waiting for a next release

from clover.

Recommend Projects