Add a Contains criteria about clover HOT 4 CLOSED

Hi! I'd like to give this a shot. Just for clarification, what field types (elems) should this function support? I see int in the example and interface in the signature.

from clover.

Hi, thank you for your interest :=)
The signature of every criteria usually accepts interface{}, so that different types can be supported.
Give a look, for example, at the In criteria, which is very similar to this one (it accepts a []interface).
You can use reflect.DeepEqual() to perform comparison of interface{} values

from clover.

You should use a type assertion to first check if it is a slice. In the case the field is not a slice, the criteria in not satisfied and you can return false. A criteria should never panic, but rather return false in such scenarios

from clover.

In the Contains function, can I assume the docValue in docValue := doc.Get(f.name) (similar to the In function) is of type slice, or maybe should it panic in the instance where it isn't a slice? Or maybe fall back to using the In function? What do you think?

from clover.