Install shell completions when using installation script about ouch HOT 11 CLOSED

Status update:

* [x]  Add completions to releases.

It's checked here but in releases there are only binaries, would be nice to see completions there, it's WIP as I understand.

from ouch.

I have a build.rs for clap_generate completions, imo help2man shouldn't be in build.rs since it requires the built binary, we could just put in ci and rely on the package maintainers. I can help packaging for nixpkgs

from ouch.

actually i take that back, i dont think help2man would need the built binary and clap should have some function to get the full help message

from ouch.

@marcospb19 don't worry about that, obviously you need permissions to copy stuff to /usr/share/, so sudo is required.

The user will be prompted for password once since default sudo timeout is 5 minutes

man sudoers:

Once a user has been authenticated, [...] the user may then use sudo without a password for a short period of time (5 minutes unless by the timestamp_timeout option).

from ouch.

It would be hard to implement completion generation for the current oof
Maybe we should just handwrite completions or rewrite oof?

from ouch.

I think that the best way it to migrate to clap, it will provide us with man pages as well as shell completions for various shells (maybe we should use a specific 3.0 beta version, while 3.0 stable is not released).

This will probably increase our binary size by 200kb, but there are various other advantages, saves us time worrying about argparsing and --help stuff (which is terrible to edit manually in ouch).

from ouch.

I didn't make the recommendation since it was previously removed
I am currently using clap{,_generate} beta and it works pretty well. I don't think clap_generate has man page support yet, but we can use help2man if we really want man pages

from ouch.

Oh yeah, I think the default template of clap is compatible with help2man, we could have a build.rs file to do it, I'm not sure how it works tho.

Removing clap was a bad decision :P , but I only realized it later.

from ouch.

It's a weird idea to install shell completions with an installation script just copying files with sudo mv, for NixOS and Arch (with AUR) we can properly install with package managers, but for ubuntu users I guess it's our only option (and other debian-based systems).

from ouch.

Oh yeah, I unchecked that one checkbox.

Taking a look again at this issue again, I'm questioning if installing shell completions with sudo in the users system is too aggressive or not, we already require sudo to move the binary to /usr/local/bin/ouch and I don't think there is another software with the same name.

from ouch.

We gave up on the installation scripts in favor of packages, after seeing that ouch is being packaged to a variety of systems.

The good part of packages is that they usually install completions correctly.

from ouch.