Error message as fucntions about forgjs HOT 10 CLOSED

Good idea, i was thinking of doing this, but i didnt have time. I was going do this for the next release but if you can help ill be realy greatul
🙏

from forgjs.

I will 👍

from forgjs.

I was thinking about the proposition you made and I dont know what behaviour we should get when the error is in multiple keys like so:

const createMinMaxIntRule = (min, max) => {
 return new Rule(
   { type: 'integer', min, max }, 
   (key, value) => `${key} must be greater then ${num}, ${value} is not enough` 
  )
} // whats te expected behaviour in the case where the int doesn't resbect both max and min 

from forgjs.

What do you mean?
the error is not related to "min" or "max", it is related to the rule in general?
for now, you can do:

const createMinMaxIntRule = (min, max) => {
 return new Rule(
   { type: 'integer', min, max }, 
   (key, value) => `${key} must be greater then ${max} and lower than ${min}.` 
  )
}

but I guess you are right maybe should be a better solution for this.

from forgjs.

Let's keep the talk here if you dont mind.
I have an other idea which is going and keep this clean and wont break copmpatibility tell me what you think of this:

const vComplexe = new Validator({
  age: new Rule({
    type: 'int', min: 18, max: 99,
  }, 'age must be integer and between 18 and 99'),
  dateOfBirth: new Rule({ type: 'date' }, 'date must be a date'),
  name: new Rule({ type: 'string', minLength: 2 }, (key, value) => ({
    type: `${key} must be a string, ${value} is not a string`,
    minLength: `${key} must be at least 2 characters, ${value} is not`,
  })),
});
vComplexe.getErrors({
  age: 16,
  dateOfBirth: new Date(),
  name: 'a',
});

I still don't know what should be returned

from forgjs.

do you want that the error will return an object of errors like this:

{
  type: 'name must be a string,',
  minLength: 'name must be at least 2 chars',
}

or

[ 'name must be a string,', 'name must be at least 2 chars',]

and how it is going to work? if fall on the first error then the other checks are not validating?

and what about the default error, if there is an error and there is no key in the error object?

from forgjs.

I think we should make another function get error in rule that goes trough all the object and returns all the errors for the rule like it’s done for validator. We can make a default error message if none is provided. Do you think this approche is right?

from forgjs.

FIrst how does the API will look like, something like this?

new Rule({
    type: 'int', min: 18, max: 99,
 }, { 
  // If the error is object it will run over the object and collect errors if needed

  type: 'type error', // you can pass error as string inside the object

  min: (key) => `${key} with min error` // you can pass errors in function inside the object

}), // but you will also need to set a default message for all the other properties that does not have message decleration (letting the user chose the default message)

and then we need to think how it will work with the existing code, because now it is just checking each propery and return true or false maybe some function like "testWithErrors" or somthing, that will test and will return array of errors at the end, if the array is empty thats mean that there is no errors

tell me what do you think about it? and do you have idea for the defaukt message?

from forgjs.

That looks good I’ll try doing the first part today i don’t want to break to much code I’ll try my best if you already have an idea on how to do it I’ll be happy to see it

from forgjs.

I will try do something later

from forgjs.