Giter VIP home page Giter VIP logo

Comments (10)

MarcOverIP avatar MarcOverIP commented on June 1, 2024 1

Agree, we should move this. Putting this for milestone v2.0.0-beta.4 (when we also revisit the exporting of templates so this can be done in one sweep)

from redelk.

fastlorenzo avatar fastlorenzo commented on June 1, 2024

User-Agent parsed data is for now put in [source][host_info]. To adhere to ECS, the different fields should be moved to [source][host][os] corresponding fields. To be done when maindev branch is stable enough.

from redelk.

MarcOverIP avatar MarcOverIP commented on June 1, 2024

Not sure Im following you, should all useragent info be put under source.host? Meaning the items in the image below should be renamed from source.host_info to source.host?

I cant see any proper reference by ECS except that this info should be stored in the root as user_agent.

image

from redelk.

fastlorenzo avatar fastlorenzo commented on June 1, 2024

This is the information for user_agent from ECS: https://www.elastic.co/guide/en/ecs/current/ecs-user_agent.html
I've checked but they don't say it if should be on root or under another key.
The best would be to put it under source I think.

We would end up with something like source.user_agent.os.name, etc (os being a sub-key under user_agent: https://www.elastic.co/guide/en/ecs/current/ecs-os.html)

Does that make sense?

from redelk.

MarcOverIP avatar MarcOverIP commented on June 1, 2024

So the only renaming required would be source.host_info -> source.user_agent? I can live with that.

Renaming is required in the Logstash config files as well as in the index templates of ES and Kibana.

from redelk.

fastlorenzo avatar fastlorenzo commented on June 1, 2024

Yes, and changing user_agent.os to user_agent.os.name

Not sure if user_agent.os and user_agent.os.name are always the same (from your screenshot)?

from redelk.

MarcOverIP avatar MarcOverIP commented on June 1, 2024

That naming of os and os_name is part of the Logstash user-agent module. The difficulty here is that the ECS user-agent documentation is not aligned with the fiels that the plugin actually adds.

Not much we can steer here. The only thing that can be done is setting the target (https://www.elastic.co/guide/en/logstash/current/plugins-filters-useragent.html#plugins-filters-useragent-target) Of course we could do post field renaming. But imho this beats the purpose of it. If it is not conform ECS Ill leave it to Elastic to update their own Logstash plugin to adhere to ECS :-)

from redelk.

xychix avatar xychix commented on June 1, 2024

This should be in 1 PR preferably with the change of the corresponding alarms!
@xychix can colaborate to make this work in 1 PR.

from redelk.

MarcOverIP avatar MarcOverIP commented on June 1, 2024

@xychix not sure about that.

@fastlorenzo see my comment on Nov 17. Do you agree that it would be ok to leave it as it is right now, and only to revisit once Elastic fixes the Logstash user-agent module to adhere to ECS?

from redelk.

fastlorenzo avatar fastlorenzo commented on June 1, 2024

@MarcOverIP I think that should be fine indeed, it is not too confusing anyways and it doesn't look like Kibana is making use of that natively.

from redelk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.