Formatting string produces error about swiftpoet HOT 14 CLOSED

Yes. Much of the CodeWriter was literally yanked from KotlinPoet as I originally sent an offer to Jake to donate this and have it hosted with the other poets and all share a community.

from swiftpoet.

Obviously somebody should be double escaping this string I'm just now sure who. At first thought just blindly double escaping every "%S" seems wrong? But I could be be wrong.

Do you know how KotlinPoet achieves this?

from swiftpoet.

One thing to remember as well is that Swift string literals allow for a fairly wide range of input (e.g. multiple code-point emojis).

from swiftpoet.

I think KotlinPoet handles it? https://github.com/square/kotlinpoet/blob/main/kotlinpoet/src/main/java/com/squareup/kotlinpoet/Util.kt#L58-L68

from swiftpoet.

hmmm seems like SwiftPoet also does this...

from swiftpoet.

Hm this is weird not seeing KotlinGenerator in Wire doing anything different than just delegating to KotlinPoet https://github.com/square/wire/blob/master/wire-kotlin-generator/src/main/java/com/squareup/wire/kotlin/KotlinGenerator.kt#L1394

from swiftpoet.

I guess the only difference I see is isConstantContext ? I think its defaulting to false in KotlinPoet and prints the string differently rather than a multi-line string.

from swiftpoet.

It looks like there's been quite a few updates to these classes since the departure.

from swiftpoet.

yeah...I am trying to test a quick case if this is the issue

from swiftpoet.

@kdubb I managed to just copy paste some parts to test it out quickly and indeed it seems to be the issue. It seems we fall under a different code path as we treat this as a multi-line string.

Looks like updating this logic to catch up to what KotlinPoet does would fix this issue.

from swiftpoet.

Can you provide a PR?

from swiftpoet.

Thanks for the investigation!

from swiftpoet.

I will give it a shot! :D

from swiftpoet.

One other thing is I've looked at this code a few times in the past because I don't think it aligns with Swift's string rules. It may be that we end up with a bit different scheme to ensure it handles Swift strings correctly.

from swiftpoet.