Giter VIP home page Giter VIP logo

Comments (10)

ghnp5 avatar ghnp5 commented on May 26, 2024 1

For example, it gives me errors for all enums used, as they're only supported in PHP 8.1 :)

from phplint.

llaville avatar llaville commented on May 26, 2024 1

Will add on my TODO list for tomorrow !

from phplint.

ghnp5 avatar ghnp5 commented on May 26, 2024 1

Thank you very much for your the work on this project. Very appreciated :)

from phplint.

llaville avatar llaville commented on May 26, 2024

Is there any reasonable reason why you don't use the latest version 9.0 ?

from phplint.

llaville avatar llaville commented on May 26, 2024

CAUTION : With previous versions 3.x, 4.x, 5.x or 6.x the cache option must specify a filename (default to .phplint-cache), while new latest version 9.0.x cache identify a directory (default to .phplint.cache)

from phplint.

ghnp5 avatar ghnp5 commented on May 26, 2024

Oh, thanks. I just wanted to ensure phplint uses PHP 8.2. But based on what you said, the tags of the docker images don't correspond to PHP versions, is that it?

How do I know which PHP version is installed on 9.0.x ? I want to make sure that my files are linted based on PHP 8.2.
Thanks!

Seems the lint worked now, but it used PHP 8.0.28 instead of PHP 8.2 :)

phplint 9.0.3 by overtrue and contributors.

Runtime       : PHP 8.0.28
Configuration : No config file loaded

....

Time: < 1 sec, Memory: 4.0 MiB, Cache: 0 hit, 4 misses


 [OK] 4 files

from phplint.

llaville avatar llaville commented on May 26, 2024

Oh, thanks. I just wanted to ensure phplint uses PHP 8.2. But based on what you said, the tags of the docker images don't correspond to PHP versions, is that it?

On legacy versions (3.x, 4.x, 5.x or .6.x) docker tag correspond to the GitHub branch of the repository.
Branch main (default) is for new major version 9.0 and Docker tag is latest

How do I know which PHP version is installed on 9.0.x ?

The Runtime line identify latest PHP 8.0 used !

I want to make sure that my files are linted based on PHP 8.2.

Actually the Workflow that generate the docker image with tag latest use PHP 8.0, but we could use PHP 8.2 to be compatible with all PHP 8 versions !

from phplint.

ghnp5 avatar ghnp5 commented on May 26, 2024

Thank you. Yeah, this was my first time using this, and I realized the Runtime line says what's the version, while I was typing my message above :)

I see the Dockerfile has 8.0 hardcoded there - https://github.com/overtrue/phplint/blob/main/Dockerfile

What I suggest is that you could generate a few Docker tags, one for each version, like:

:9.0-php8.2
:9.0-php8.1
:9.0-php8.0

And then we could choose which to use, depending on what we use for our application.

For now, I might go ahead and create my own local image (replicating your Dockerfile, changing the version to 8.2), but here's my suggestion anyway :)

Thanks very much!

from phplint.

llaville avatar llaville commented on May 26, 2024

Workaround is to use the PHAR distribution that really depends of your platform (PHP runtime), until docker images are available !

from phplint.

llaville avatar llaville commented on May 26, 2024

@ghnp5 I'll close this report, because fix will be applied on issue 180.

from phplint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.