Giter VIP home page Giter VIP logo

Comments (6)

kingthorin avatar kingthorin commented on July 17, 2024

Refs:

from wstg.

ThunderSon avatar ThunderSon commented on July 17, 2024

@kingthorin this can be closed, right? Or you think that we need to anything further? I set in the PR template a box to say that the issue has been fully covered, in a way to say go ahead and close it :)

from wstg.

kingthorin avatar kingthorin commented on July 17, 2024

The one template still needs the label element set. I can do that if you want (let me know). "QA/Edit"

On that commit/PR a keyword can be used to close this. https://help.github.com/en/articles/closing-issues-using-keywords

from wstg.

ThunderSon avatar ThunderSon commented on July 17, 2024

We'll need to make it a conditional, and what if the PR does not properly close the issue?

from wstg.

kingthorin avatar kingthorin commented on July 17, 2024

Labels can always be changed after the fact, plus the user can tweak it at creation. To me it's more often applicable than not.

As for closing keywords, I meant specifically you could use that for this one. Not that it should be part of the template. For other instances, if a user incorrectly closes with a keyword that should be caught during PR review and if missed then the issue can be manually re-opened.

from wstg.

ThunderSon avatar ThunderSon commented on July 17, 2024

For the label we're at an agreement. As for the closing, alrightie.

from wstg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.