TravisCI version4 build fails to complete javadoc generation for JDK6 about owlapi HOT 8 CLOSED

Picture me puzzled here - guava is a dependency of the code, why is the
build trying to compile it? I wonder whether it's trying to do the same on
my local build, I'll have a look.

There is also a separate problem with openjdk 6 - it fails IRITest, at
least occasionally.

On 29 May 2013 02:04, Peter Ansell [email protected] wrote:

The TravisCI build for version4 fails when it tries to complete the
javadoc generation for JDK6:

[ERROR] Exit code: 1 - /home/travis/build/ansell/owlapi/distribution/target/distro-javadoc-sources/guava-14.0.1-sources/com/google/common/base/Preconditions.java:24: cannot find symbol
[ERROR] symbol : class Nullable
[ERROR] location: package javax.annotation
[ERROR] import javax.annotation.Nullable;

The cause seems to be that the jsr305 annotations are not included by
default, according the guava website. It is not clear why it succeeds on
Java7, but a fix should be to explicitly add the jsr305 annotations as
maven dependencies wherever guava is used.

https://code.google.com/p/guava-libraries/wiki/UseGuavaInYourBuild

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18
.

from owlapi.

I'm willing to add JSR305 as a dependency as those annotations are tempting for use in the OWL API as well, but I wonder why this issue is coming up at all - shouldn't dependencies be pulled in in their binary form?

from owlapi.

According to the link in the issue, the Guava developers at Google seem to have a specific policy not to include that dependency, even though that is what Maven (and other similar systems) are designed for. So, no, it won't be pulled in binary form in this case due to a specific choice to make it not happen automatically.

from owlapi.

I understand that, what I do not understand is why the error message appears to say that /guava/ cannot be compiled because of a missing dependency. The OWL API is not using JSR305 annotations yet.
It looks to me like, during the build of OWL API, the source for guava is being built as well. This leaves me puzzled, and it is not happening locally or in the other builds, including the OpenJDK 7.

I have added JSR 305 as a dependency and we'll see if this fixes the issue, but I'm far from convinced that this is the root issue.

from owlapi.

Ah there it is. The distribution javadoc plugin has a flag to include dependency sources.

from owlapi.

And its include and exclude tags are upside down - ah the humanity. That's been broken for ages without anyone noticing, and until now without anything breaking because we had no external dependencies.

Just committed the fix.

from owlapi.

The build just passed. I'm still not convinced about why at the beginning only one of the builds was failing, then all three failed - but I can live with not knowing.

from owlapi.

I don't have experience with javadoc and the assembly plugin, or guava, so I can't speculate on why only one was failing either.

from owlapi.