Giter VIP home page Giter VIP logo

Comments (14)

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024 1

No. I like to leave them open until the issue is fixed so that others can know that the issue has already been reported.

This fix should arrive in the next release.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024

Hm. Another strange issue from Samsung's MediaStore flavor.

Can you make sure that the "Show Covers" setting is on in the settings menu?
If it is on, then see if anything happens if you turn on the "Ignore MediaStore Covers" setting.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024

I say this because the file works fine on my device [Pixel 5 Android 11] and seems to be pretty well-formed ID3v2 metadata.

Screenshot_20211009-085321

So this is either:

  1. Covers being off in Auxio
  2. Samsung's MediaStore being annoying again.

from auxio.

nswerhun avatar nswerhun commented on August 11, 2024

Hm. Another strange issue from Samsung's MediaStore flavor.

Can you make sure that the "Show Covers" setting is on in the settings menu? If it is on, then see if anything happens if you turn on the "Ignore MediaStore Covers" setting.

"Show Covers" is on. "Ignore MediaStore Covers" does not make a difference, on or off. Is there anything I can do about Samsung's MediaStore?

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024

Oh.

I have a pet theory that Samsung's implementation of MediaStore, the Media API that Auxio relies on, is deliberately crippled so that their built-in music app has advantages. Artists will get mixed up, certain metadata just won't be available despite being tagged, and I think that their music app uses some proprietary extensions to load it's music that other apps don't have access to. As far as I know, there's nothing you can do about it.

What our the other players that allow cover art to work? I know that Vanilla/VLC have their own in-house metadata parsers to get around the issue, and other players like Retro, Pulse, and Canaree can fetch cover art from last.fm, also circumventing the issue.

from auxio.

nswerhun avatar nswerhun commented on August 11, 2024

VLC, Vanilla, and Metro all work. Curiously, in Metro, the setting to ignore MediaStore covers is enabled by default, and the covers work fine.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024

VLC, Vanilla

Expected, they don't rely on MediaStore

Metro

Now thats strange. I'll drop by their repo and see what they do, because as I said they might be querying last.fm for covers when that setting is on.

from auxio.

nswerhun avatar nswerhun commented on August 11, 2024

... they might be querying last.fm for covers when that setting is on.

These files I have tagged myself with my own image. It is often not the "official" album cover. That is the case with the file I provided; it was a pretty picture I found on Google which I thought went well with the music. I don't think they could be getting it from last.fm in this case.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024

Figured it out. Retro/Metro uses two fallbacks if it can't manually extract the cover:

  1. Use JAudioTagger to parse the file
  2. Try to find a related cover photo in the same directory

This would explain why it works on your device. Sadly, Auxio can't use those methods because it would require ignoring scoped storage with the requestLegacyExternalStorage manifest flag, which is deprecated and set for removal.

However, ExoPlayer [Which Auxio relies on] has it's own metadata parser that does work with scoped storage. I could theoretically use that parser as a fallback when the normal cover parsing fails and fix this problem. In fact, I could just cut out the middleman and use the ExoPlayer parser instead of the MediaMetadataRetriever API to load covers without this annoying garbage occuring.

I'm a bit busy right now, but when I get the time I'll try reworking my cover system to do this.

from auxio.

nswerhun avatar nswerhun commented on August 11, 2024

Glad you have an idea on how to fix it. I really like the app, other than this issue great job. Should I close the issue?

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024

Can you try out this test APK? I've made the change.

Auxio_BetterCovers.zip

Some things to know before trying this out:

  • You will have to rename this file to .apk to install it
  • This build has the new 2.0.0 design I've been working on, the settings will be in the overflow menu at the top right.
  • "Ignore MediaStore Covers" needs to be turned on settings, otherwise the cover art loader will optimize for speed and only use the android-generated covers [Which in your case won't work]
  • I could only get it to work with ID3v2 and FLAC metadata, as those are the only formats ExoPlayer can internally fetch pictures from.
  • The ExoPlayer parser is slower and doesn't cache as easily. However, since it's a fallback this is tolerable.
  • Artist and genre image won't work yet. This will be included in the fix.

Hope this works for you.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024

I've not received a response yet, so I'm going to commit the fix now. If you still have problems, please let me know.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 11, 2024

Re-opening since it turns out that my exoplayer solution results in a blocking call and breaks the image loading process in a subtle and frustrating way. I have no idea how to fix this.

from auxio.

Tom4tot avatar Tom4tot commented on August 11, 2024

Hi. Just switched to Galaxy S24 and I'm facing the exact same issue. I think it did work at some point for some albums but it doesn't anymore. Fun fact, it makes the app much smoother (so your explanation was indeed accurate: #579 (comment) ).

If you have any ideas I'll be happy to test them. Currently, my covers are not embedded in files but in the same folders as a .jpg file. Would it help to embed them?

(Interestingly, covers don't show up either on Samsung's app)

from auxio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.