Comments (3)
Thank you for the extremely detailed report @unrenowned. I actually made this change because:
- Media3's interface requires a more standard "move" operation rather than my swap behavior.
- I thought the swapping was actually a no-op since I forgot about this index shifting edge case. I'm pretty sure this is why I was swapping in the first place to more or less hack around it.
The underlying timeline is altered when the shuffled queue is re-arranged, and mutating/replacing the shuffle order itself is a huge performance hit since it triggers a full reload of the player state. I need to find a way to avoid re-introducing the swap behavior since it can no longer work when external apps do a direct move but Auxio internally is only expecting swaps.
from auxio.
LOL, I figured out this issue months ago and thought it was my problem: androidx/media#954
Yeah. It legit does not update the shuffle order when you move it, I have to do it. I wouldn't know how to patch this in myself since ExoPlayer internals are so nightmarishly difficult to use.
from auxio.
Re-added old swap code. I don't care if larger moves break it, Android Auto probably doesn't make those anyway. Will wait for them to do androidx/media#1381
from auxio.
Related Issues (20)
- Can a mini player overlay be used to play files directly? HOT 1
- I wish they'd eliminate the white space on the album cover. HOT 2
- Added a feature to stop music playback and close the app when the app is removed from the "Recently Used Apps" list by swiping it. HOT 1
- Development is slow right now HOT 2
- Swiping down on More Options creates an empty menu HOT 2
- Dynamic playlist sorting HOT 4
- Sorting songs by date does not work as expected HOT 1
- Redesigned playlist selection HOT 1
- Warn before adding duplicate songs in playlists HOT 11
- Support for android auto HOT 1
- Experiment with caching music grouping
- Do not load cover art in music loader HOT 8
- Repeat does not work HOT 4
- Name sorting not working properly HOT 1
- Overscroll to refresh library HOT 1
- Disabling auxio service HOT 2
- Track cover is displayed wrong HOT 3
- sort artists/albums/playlists by recently played HOT 2
- Full cache reload after 3.5.0 crashes HOT 18
- Import folders as playlists HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auxio.