Giter VIP home page Giter VIP logo

Comments (5)

p2 avatar p2 commented on August 21, 2024

I was thinking about this, GitHub for example does not issue expires_in. Best way would probably be to test if the token still works, which would require a URL. Could be a setting like token_test_url or something.

(BTW I changed this log entry just recently to be more informative)

from oauth2.

paulwilton avatar paulwilton commented on August 21, 2024

yes Instagram Oauth2 implementation also does not send expires_in :
"Even though the access token does not specify an expiration time, your app should handle the case that either the user revokes access, or Instagram expires the token after some period of time. In this case, your meta of your responses will contain an “error_type=OAuthAccessTokenError”. In other words: do not assume your access_token is valid forever."

from oauth2.

paulwilton avatar paulwilton commented on August 21, 2024

reading this it might be best to use a combination of the suggested approaches for dealing with this, i.e. use an estimate for token expiry and a test at the end of that estimate if expiry is not supplied :
https://rnd.feide.no/2012/04/19/best-practice-for-dealing-with-oauth-2-0-token-expiration-at-the-consumer/

(excellent work on this lib by the way :)

from oauth2.

p2 avatar p2 commented on August 21, 2024

The develop branch now has accessTokenAssumeUnexpired, which is true by default, to handle these cases.

from oauth2.

p2 avatar p2 commented on August 21, 2024

This is now in 1.2.7.

from oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.