Giter VIP home page Giter VIP logo

Comments (8)

victornoel avatar victornoel commented on June 19, 2024

@ganeshs could you include extra informations such as how guice is setup too? I have never used guice so it would be helpful.

Actually, the best would be some kind of test case such as in the dropwizard-pac4j tests but with guice instead of hk2… :)

from dropwizard-pac4j.

ganeshs avatar ganeshs commented on June 19, 2024

In my scenario, guice was setup using the bundle https://github.com/gojek-engineering/gojek-commons/blob/master/gojek-commons-guice/src/main/java/com/gojek/guice/GuiceBundle.java

I will try to put up a test case for guice integration. I have already come up with a fix for this issue in the pac4j jax-rs module. Will raise a PR for that in a while

from dropwizard-pac4j.

ganeshs avatar ganeshs commented on June 19, 2024

@victornoel Raised a PR for this in the jaxrs module. pac4j/jax-rs-pac4j#42

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

@ganeshs once the latest SNAPSHOT of jax-rs-pac4j is built, could you validate everything works as you expect it?
It would also be excellent if you could make a small test using guice in dropwizard-pac4j :)

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

@ganeshs did you get some time to confirm everything is ok? you should be able to use dropwizard-pac4j 3.0.0-SNAPSHOT for your tests :)
I also backported your PR to 2.x btw.

from dropwizard-pac4j.

ganeshs avatar ganeshs commented on June 19, 2024

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

@ganeshs have you had the time to validate everything is ok? We are going to release dropwizard-pac4j 3.0.0 soon btw (see pac4j/jax-rs-pac4j#44)

from dropwizard-pac4j.

victornoel avatar victornoel commented on June 19, 2024

I'm closing this, please open a new issue if this is still a problem :)

from dropwizard-pac4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.