Giter VIP home page Giter VIP logo

Comments (11)

ghachey avatar ghachey commented on August 23, 2024

@maratomega Please share progress on this one.

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

@ghachey if we will remove this certificate, the app will crash if the user won't have the internet connection. Tested on our side without internet, it crashes once the user selects the country.
We can keep this cert without any harm, but if you require us to remove it we will need to show some error pop-up

Please share your thoughts.

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

@maratomega ok we can keep. But it looks like an old key. Can you try replacing the key with the one I sent you through Skype.

I believe the place to replace is app/src/main/assets/c_dev.json

And see if it still all behaves correctly. Also, this could be related to issue #68 as this old server_account key is from the "Education Survey Tool Base" project. Is this key used in any way once the country is selected and a production key retrieved?

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

In meeting it was discussed that:

  • We may be able to remove this local settings without crashing the app with the proposed approach in #68 (comment)
  • If so, please also let's try to remove the hard coded keys in the source code (e.g. app/src/main/assets/c_dev.json)

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

@maratomega what is the progress on this?

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

Completed

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

@maratomega I installed the latest build and I still see in the settings "Load PRoduction Certificate", is there a reason why this local settings is still there? I thought you said this issue is complete, can you elaborate a little?

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

@ghachey we haven't removed from the settings "Load Production Certificate" because of issues with the internet connection, it prevents the app from crashing.

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

@maratomega I thought you said following the approach of per country builds would no longer require this old key to keep the app from crashing without Internet?

from pacific-emis-education-survey-tool.

maratomega avatar maratomega commented on August 23, 2024

@maratomega I thought you said following the approach of per country builds would no longer require this old key to keep the app from crashing without Internet?

During the testing without it, on the per country builds, we still had that issue.

from pacific-emis-education-survey-tool.

ghachey avatar ghachey commented on August 23, 2024

@maratomega I thought you said following the approach of per country builds would no longer require this old key to keep the app from crashing without Internet?

During the testing without it, on the per country builds, we still had that issue.

Can you at least hide the config from the user local settings?

from pacific-emis-education-survey-tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.