Customization is overly complicated? about hacker HOT 4 OPEN

Hi @ensonic

I don't see any problem about it. It's fine have stylesheets modularized. I mean.

• This file to define colors by name:
  https://github.com/pages-themes/hacker/blob/master/_sass/_default_colors.scss#L1:L27
• This other to assign a variables according to rules (see the top).
  https://github.com/pages-themes/hacker/blob/master/_sass/jekyll-theme-hacker.scss#L1-L27

What do yo think?

from hacker.

This is now 6 month later ... My report was about 2 things:

1. avoid the need to copy the header definitions
2. imho the change should not leave commented out variable in the css, either it is needed of not. If the developer is unsure, if a bug and describe the concern.

from hacker.

I'm a simple user as you, using this theme giving advice about why is coded like this.

You don't need to comment anything.

As I said, leave the variable in colors and override it where you need. Even more, you can add another SSAS @import with your customs to don't lost defaults.

Moreover all github themes have the same structure.

from hacker.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from hacker.