[Feature] Set dark background colour for search and status bar on mobile devices about hacker HOT 5 CLOSED

Hey @olifre

Nice enhacement.

Since document is HTML5 doctyped, close meta tags are not needed. To maintain same code guidelines on entire template I recommend remove the trailing slash.

The color #151515 matches with defined for body background...

Then the snippet looks as some like this:

<!-- Chrome, Firefox OS and Opera -->
<meta name="theme-color" content="#151515">
<!-- Windows Phone -->
<meta name="msapplication-navbutton-color" content="#151515">
<!-- iOS Safari -->
<meta name="apple-mobile-web-app-capable" content="yes">
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">

What do you think about?

from hacker.

Did you already test this with a Safari mobile browser?

Sorry, me neither, no iPhone 😣

I've been taking a look at some webs, also the other themes and in Cayman was approved with black-translucent and not -capable
pages-themes/cayman@fa96379

There are enough top gap how to allow overlap mode, so black-translucent it's fine. With black it would also look good due to this theme has a quite dark background color.

So... both are valid for me.

<!-- Chrome, Firefox OS and Opera -->
<meta name="theme-color" content="#151515">
<!-- Windows Phone -->
<meta name="msapplication-navbutton-color" content="#151515">
<!-- iOS Safari -->
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">

<!-- Chrome, Firefox OS and Opera -->
<meta name="theme-color" content="#151515">
<!-- Windows Phone -->
<meta name="msapplication-navbutton-color" content="#151515">
<!-- iOS Safari -->
<meta name="apple-mobile-web-app-status-bar-style" content="black">

Fix it as you wish 😉. I review your PR if I can 🤗.

from hacker.

I think I'd also expect black-translucent to work fine, and not specifying -capable seems more safe to me. While this does not match the Safari documentation, the screenshot you found seems to show it works nevertheless, and it seems more safe since it does not change other behaviour 😉.
I can also only suggest here, we'll have to wait for someone with commit privileges to review and merge.

from hacker.

What do you think about?

That looks like several great improvements, thanks for this research 👍 !
Did you already test this with a Safari mobile browser? I don't have access to one, but a test might be worthwhile to check if there are also unintended side-effects from the "capable" meta tag.

from hacker.

Yep.

The screenshots are captured using a Samsung S5 on Chrome.

I hope that any admin approve and release. It seems that theme projects are a bit abandoned.

Meanwhile there will be to wait for Travis CI build

from hacker.