Comments (11)
thanks for the report @KamilSJaron and for including session info!
@dill any ideas? This seems clearly linked to the change made in #26 #28 From this report, seems like perhaps there was a good use case for the old version of add_phylopic_base()
that used par()
- I wonder if we can sort out the high level use cases here and ideally support all of reasonable ones. Is there just two use cases that we can use a parameter to toggle between?
from rphylopic.
Hi folks, sorry for the delay, I was doing a fieldwork (collecting the right silhouettes). I will take a look shortly.
from rphylopic.
Thanks for checking! I liked the previous specification, but since it was causing issues for people in terms of output we had to switch (rather have functionality in all cases over ease of use) but if you think of a way of getting it working (even just as a quick example, not a full PR) feel free to open an issue and I'll look into it :)
@sckott can the PR be merged now?
from rphylopic.
yes
from rphylopic.
ah bummer, I thought we'd got this sorted. I'll take a look and post back when I have a chance. Sorry about the hassle @KamilSJaron!
from rphylopic.
thanks @dill
from rphylopic.
No worries, thanks to you for making am r interface for phylopic!
from rphylopic.
Sorry for the delay, a bunch of other work stuff came up. I've tried to fix this in this PR.
I've also added an xsize
argument to allow for any fine-grained adjustment in case the automatic version doesn't work (again!).
Let me know if this works for you :)
from rphylopic.
@KamilSJaron if you have time can you test the solution in pull request #30 - should be able to install like remotes::install_github("dill/rphylopic")
from rphylopic.
Hi there, I tried and it does work. With xsize it will be always possible to plot a silhouette in any possible size including all distortions.
To be completely honest, I liked the previous behaviour better than this one (specifying always relative coordinates). I will think if there would be an easy way to allow both absolute and relative coordinates / sizes.
from rphylopic.
🍻
from rphylopic.
Related Issues (20)
- Example with silhouettes used NOT as points
- geom_phylopic requires image to be in a list
- Use /collections API endpoint HOT 2
- Add reminder to attribute silhouette creators on package load HOT 1
- silhouette legend for base R HOT 2
- Reflect size aesthetic in key_glyph_phylopic
- On load message HOT 1
- coord_sf and silhouette size
- Silhouette outlines being added by default
- Release rphylopic 1.2.1
- Release rphylopic 1.2.2
- Include rphylopic citation in get_attribution text
- Cheat sheet updates HOT 1
- pick_phylopic should take uuids
- Release rphylopic 1.3.0
- Add options for justification (e.g. vjust and hjust similar to geom_text()) HOT 1
- Specify width, instead of height, when plotting phylopics HOT 10
- pick_phylopic no longer prints attribution information in menu
- Release rphylopic 1.4.0
- Implement vcr to make tests work offline
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rphylopic.