Comments (3)
nmiyake
commented on June 2, 2024
Thanks for the feedback. Just for clarification, is it the case that the current Close() and Shutdown(context.Context) functions do close/shut down the server, but cause the start function to just return nil rather than an error?
from witchcraft-go-server.
ryanmcnamara
commented on June 2, 2024
Yup, exactly
from witchcraft-go-server.
nmiyake
commented on June 2, 2024
Got it. Yes, I think this is reasonable -- would just say that, in the comment/documentation for the function, you should note that the function is the equivalent of calling Shutdown, but will return a non-nil error. I think it would also make sense for the PR to update the implementation of Shutdown to use ShutdownServer with a nil error.
from witchcraft-go-server.
Related Issues (20)
- Runtime config refreshable produces zero value if cannot parse yaml
- pprof/goroutine returns 404 HOT 2
- Add a default health check for a sliding window of events HOT 1
- TestNewInflightLimitMiddleware test flakes
- Separate out trace sampling for application routes and management routes
- Allow selecting which go metrics you care about to emit HOT 4
- Default server/client metrics too verbose, no option to trim down HOT 10
- log canceled request as 499 instead of 500 HOT 8
- Reduce default trace rate to 1%
- 404s do not produce request logs
- Opt-in diagnostic log upon turning unhealthy HOT 5
- Improved panic logging
- Liveness endpoint should return non-empty JSON object
- Metric loggers should emit 0 value before regular value for certain metric types HOT 1
- connection metrics
- Encrypted values in configuration should be decoded while maintaining YAML structure
- RouteHandlerMiddleware unwieldy for endpoint-specific handling
- Missing pprof routes
- Library equivalent to Java's ManagedScheduledTask
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from witchcraft-go-server.