Error raised when query has invalid encoding about isolator HOT 3 CLOSED

Good idea about safe_match?.

Though, instead of catching ArgumentError and returning nil (which would ignore that occurrence I suppose), maybe we can replace invalid occurrences with blank string as suggested here 🤔

from isolator.

Yeah, I like it. I guess, here is the code snippet we can use: https://github.com/thoughtbot/griddler/blob/2ae3a99b8c59d8c68adffd6e109b1b83fd32f26e/lib/griddler/email.rb#L153-L159

from isolator.

Thanks for reporting!
That's an interesting case.

I'm available to submit a PR for the fix.

That would be awesome!

I think, subscribing to an event shouldn't break the actual code execution (that's probably an ActiveSupport::Notifications concern 🤔).
As far as I can see, the only code that could raise and out of our control is Regexp#match?.

So, I suggest adding a safer version, say, Regexp#safe_match? which catches ArgumentError and return nil. And we can use a Refinement for that! WDYT?

from isolator.