add proxy support about alembic HOT 7 CLOSED

Maybe we should default the proxy information, in the same way leiningen does

from alembic.

I thought about it already.
I'll try

from alembic.

As I had the proxy values passing already working, I left it in.
But if no proxy parameter is specified, then it reads it via the method from leiningen.core.classpath path as you suggested.

So the function where the proxy config is the really used looks like this:

(defn resolve-dependencies
  [still dependencies repositories proxy]
  (classlojure/eval-in
   (:alembic-classloader @still)
   `(do
      (require '[leiningen.core.classpath :as ~'cp])
      (mapv
       (fn [dep#]
         (letfn [(apath# [^java.io.File f#] (.getAbsolutePath f#))]
           {:coords dep#
            :jar (-> dep# meta :file apath#)}))
       (keys
        (aether/resolve-dependencies
         :coordinates '~(vec dependencies)
         :repositories ~repositories
         :proxy '~(or proxy (cp/get-proxy-settings)  )))))))

What do you think ?

from alembic.

I made as well a version which always uses the environment variables without a way to override the proxy configuration via function parameters.
It's less code changes, so simpler.

Let me know, which version you prefer and I send a new pull request.

from alembic.

I think I would favour having the default picked up from the environment, and still being able to explicitly overide.

from alembic.

OK.
The pull request is updated.

from alembic.

Fixed in 8ced4ed

from alembic.