Giter VIP home page Giter VIP logo

Comments (5)

gramster avatar gramster commented on August 23, 2024 1

Ah, got it. For various reasons I sometimes hack importlib to get it to import .pyi files rather than .py files, so my concern is that would break for me with this name change. But if that's what poetry wants, can't argue.

from pandas-stubs.

breno-jesus-fernandes avatar breno-jesus-fernandes commented on August 23, 2024

Hi I guess I am responsible for this chance. To simplify the project I added "poetry" to manage and distribuite the project easily. So, poetry build a wheel to a "stubs only package" if the stubs dir follows the pattern "package-stubs", following strictly the PEP 561.

from pandas-stubs.

breno-jesus-fernandes avatar breno-jesus-fernandes commented on August 23, 2024

If any new doubt or suggestions happens open a new issue, I'll be happy to help ;)

from pandas-stubs.

Dr-Irv avatar Dr-Irv commented on August 23, 2024

I'm a bit surprised that you would rename the top-level directory of the stub files to something other than pandas. Surely it should reflect the package/main module name?

(This change also broke our github actions to pull stubs from here, but that's our problem. In investigating the break I noticed this change and it seems wrong to me to use this name. Want to raise this ASAP in case it results in further changes).

The other reason I agreed to do this is because we're going to install the package as pandas-stubs once I get things onto pypi and conda-forge, so that was another reason for doing this change. It makes it easier for us to test how things will look for people if they install the package.

I forgot to tell you that this was happening, as I had a sense it would break something on your end. Apologies for that.

from pandas-stubs.

Dr-Irv avatar Dr-Irv commented on August 23, 2024

@gramster I'm going to close this - assuming conversation resolved the issue, but if not, feel free to re-open

from pandas-stubs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.