Comments (8)
Thanks @pomartel ! I failing test would be amazing
from memo_wise.
After doing a few more tests, it seems the regression is related to Rails concerns. If I take the memoized method out of the concern and put it directly in my model, then it works as expected. I don't think I can write a test for that since Memowise is not Rails specific. If I rollback to Memowise v1.1.0 then the memoized concern method works fine. Is there anything I could provide to help with this?
from memo_wise.
What I'd recommend is that we find a minimal test reproduction.
Is it possible for you to describe the steps to trigger this in a Rails app? We can then reproduce, and work towards a minimal test case possible just using ActiveConcern?
from memo_wise.
I spent quite a few hours trying to come up with a minimal test case and I'm really puzzled. I think it comes down to the way this all integrates in my app and the fact that I was including Memowise twice:
class MyModel < ApplicationRecord
prepend MemoWise
include MyConcern
end
# THIS SEEMS TO CAUSE A REGRESSION WITH MEMOWISE 1.2
concern :MyConcern do
prepend MemoWise
def method_to_memowise
true
end
memo_wise :method_to_memowise
end
# THIS WORKS
concern :MyConcern do
included do
memo_wise :method_to_memowise
end
def method_to_memowise
true
end
end
The second one works fine so I will close the bug report as it looks to be something related to my code implementation.
from memo_wise.
Hi @pomartel! Thanks for digging into this! I'm glad you got something that works for you but I'm still interested in digging into this issue to see if there's a broader fix we can make in this gem. I'm having trouble reproducing what you're seeing though; I couldn't get the exact syntax you had to run but I tried this:
require "memo_wise"
require "active_support/concern"
module MyConcern
extend ActiveSupport::Concern
included do
prepend MemoWise
def method_to_memowise
true
end
memo_wise :method_to_memowise
end
end
class MyModel
prepend MemoWise
include MyConcern
end
puts MyModel.new.method_to_memowise
When I run this with MemoWise
1.2.0 it prints "true" as I'd expect. What do I need to change to get my reproduction to work?
from memo_wise.
We also just released v1.3.0. Can you see if you still see errors in that version?
from memo_wise.
Ah! Yes, v1.3.0 did fix it! I am glad it did because I was trying hard to create a minimal Rails project to reproduce the issue and I just could not reproduce it. The bug only manifested in the app and not in the console. I was getting a nil value instead of a boolean. I saw in the recent commits something about thread safety (b807114). I think that fixed it! Thanks for following up. I think this can be closed now.
from memo_wise.
So glad to hear it! I think this was probably related to the inheritance issues we fixed in #229
from memo_wise.
Related Issues (20)
- Investigate whether we can speed up tests
- Method arguments with specific names can be overwritten
- Create easier way to compare changes against current `MemoWise` version HOT 1
- Broken handling of inheritance after "Optimize zero-argument methods" HOT 4
- Avoid defining methods unless needed
- Use squiggly heredocs everywhere
- Multiple composition inheritance bug HOT 8
- Error memo_wising in subclass with included module HOT 2
- Tidy CHANGELOG
- Use method-specific instance variables for methods that take arguments HOT 1
- Use nested hashes instead of arrays for methods with multiple required arguments HOT 2
- Array data structure leading to multiple bugs
- Release 1.4.0 breaks simple inheritance HOT 4
- Cannot use memoized class level method in sub classes HOT 5
- Fix thread safety tests which are non-deterministic on TruffleRuby
- SystemStackError when memoized method calls memoized super method HOT 2
- memo_wise raises error when memoizing a method in a module that's included in a class that overrides `initialize` HOT 1
- Sorbet compatibility
- Documentation: Add alt_memery & memoist3 to performance comparison table HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memo_wise.