[BUG] Registered commands do not work about chimera HOT 3 CLOSED

Ok, I found out what the problem was. If the command is declared in the plugin.yml, it will not register because of this check:

public DispatcherCommand register(LiteralCommandNode<CommandSender> command) {
    if (this.map.getKnownCommands().containsKey(command.getName())) {
        return null;
    } else {
        DispatcherCommand wrapped = this.wrap(command);
        this.map.register(this.prefix, wrapped);
        return wrapped;
    }
}

Is this intended? Maybe this should be documented

from chimera.

It is intended, the reason why we check if map.getKnownCommands() already contains the given command is to prevent people from accidentally overriding commands that they (or other plugins) already registered. That said, I won't recommend using scribe to register commands.

Scribe has been slated for removal in 4.9.0 since from my understanding no one really uses, putting into question the maintenance-to-benefit ratio. Secondly, I just no longer believe that annotations to plugin.yml is the best solution. Going forward, I probably will be writing a lint for plugin.ymls that potentially replaces placeholders with values from a pom.xml/other build files but I digress.

If you're interested in using annotations to register commands, I would recommend using the new typist project. It's a revamped & repackaged version of creating commands with annotations. It is pretty much feature complete, but we're still in the midst of testing and fine-tuning it.

Lastly, I agree that this behaviour should have been documented, thanks for highlighting it.

from chimera.

Thank you for your detailed explanation!

from chimera.