Crash after trying to create a user with email still present in soft deleted scope about aoz-003 HOT 8 CLOSED

We should add a uniqueness validation on users.email

from aoz-003.

Instead of a unique index?

from aoz-003.

In addition to :) All unique indexes should have a corresponding validation, so the error can be caught earlier.

IMHO Rails should have integrated something like https://github.com/SchemaPlus/schema_validations long ago.

from aoz-003.

Sounds like a plan.
But how are we going to handle the case a user is soft deleted and again created... with the same email?
Somewhat of an edge case, but not totally irrelevant. They may want to do that.

from aoz-003.

how about using gem 'schema_validations' ?

from aoz-003.

But how are we going to handle the case a user is soft deleted and again created... with the same email?
Somewhat of an edge case, but not totally irrelevant. They may want to do that.

Yeah I was thinking about that too, I see a few different options:

• automatically reactivate a deleted user on creation (including all their associated data)
• block creation, let admins deal with reactivating the user
• change email address on deletion (e.g. add +deleted@)

Definitely something to discuss with the customer :)

Was there a specific motivation for using the paranoia gem, besides actual paranoia?

from aoz-003.

how about using gem 'schema_validations' ?

I haven't used it yet but it looks solid, definitely something we could do if we have the time.

from aoz-003.

automatically reactivate a deleted user on creation (including all their associated data)

That looks like the best solution to me. Especially because the newly recreated user will also have all its relations still in place.

from aoz-003.