Giter VIP home page Giter VIP logo

Comments (6)

panva avatar panva commented on August 20, 2024

This is not a bug, it's just an ES Next language feature not available to older node versions. You can see [email protected] has a runtime requirement of node >=12.0.0 right in the readme.

You can also see extensive CI of both projects

from jose.

josh-egan avatar josh-egan commented on August 20, 2024

Ah, I see. I hadn't seen that syntax before. Sorry for the bad issue.

from jose.

panva avatar panva commented on August 20, 2024

No problem.

Node >=12.0.0 is the described minimal version in both projects README's as well as package.json (so during npm/yarn install you must've omitted a warning). It is for its KeyObject and crypto module additions that are only available in the Node 12 trackk. This new private class fields syntax is just something which iā€™m glad to have available as a side effect.

from jose.

panva avatar panva commented on August 20, 2024

#37 https://v8.dev/features/class-fields

from jose.

panva avatar panva commented on August 20, 2024

I've made @panva/jose compatible with lts/dubnium, it is now being tested with Node.js ^10.13.0 || >=12.0.0 and Electron ^6.0.0

It is not without caveats, but they are acceptable.

  • Importing X.509 certificates and handling x5c is only supported when Node.js >= 12.0.0 runtime is detected
  • OKP keys are only supported when Node.js >= 12.0.0 runtime is detected

from jose.

josh-egan avatar josh-egan commented on August 20, 2024

Cool, sounds great, thanks! I think supporting active LTS versions of node is a great idea. In my particular case, upgrading to node 12 wasn't a problem, so I upgraded our project to node 12.x and both oidc-provider and @panva/jose have been working great. šŸ‘

from jose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.