Comments (4)
professor
commented on August 28, 2024
I'm curious how "bad" is it if PaperTrail is leaking whodunnit between threads.
from paper_trail.
professor
commented on August 28, 2024
new(blocking: false, storage: true)
If the storage is unspecified, the default is to inherit a copy of the
storage from the current fiber. This is the same as specifying
storage: true.
This seems like it could be a problem in using RequestStore and Fibers. It's up to puma, thin, sidekiq to make sure that the storage is set to nil, otherwise the RequestStore will have cross Fiber pollution.
I've created this issue: steveklabnik/request_store#98
from paper_trail.
professor
commented on August 28, 2024
Once this is merged: steveklabnik/request_store#99, I'm hoping that paper trail master will be green again!
from paper_trail.
professor
commented on August 28, 2024
With the new release of request store 1.7.0, paper_trial is now green on master!
from paper_trail.
Related Issues (20)
- Change the Versions table name HOT 4
- Support Rails 7.1 HOT 5
- Drop RequestStore in favor of ActiveSupport::CurrentAttributes HOT 6
- errors are not raised when update, update_columns, or destroy versions fail to create HOT 2
- Install migrations --with-changes use text column but PaperTrail errors with expecting JSON or JSONB HOT 1
- `versions` association adding an additional and invalid ORDER BY statement HOT 3
- Only track changes for updates; still track creation and destruction events HOT 3
- Incompatible with ActiveRecord 7's composite primary keys HOT 4
- Ignore certain columns by default HOT 4
- yaml_column_permitted_classes warning never actually gets output HOT 2
- `PaperTrail::Version.where_object` cannot not find serialized values in YAML object HOT 1
- Date/DateTime leads to empty changeset HOT 4
- Ability to conditionally set metadata on a version record depending on the event (create, update, etc) HOT 1
- `versions` raises error whenever `PaperTrail::Version` is a parent to an abstract superclass HOT 1
- Empty "update" versions when using active storage HOT 5
- errors are not raised when update, update_columns, or destroy versions fail to create HOT 2
- reify tries to set the value for a read_only attribute HOT 2
- When using papertrail with mock models papertrail takes the wrong `item_type` HOT 1
- Calling has_paper_trail on STI models causes 2 inserts to versions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paper_trail.