Comments (18)
But, what is hard in patches? Just change project code, rebuildPatches.sh, git commit, git push
from waterfall.
They are completely able to contribute. If they don't want to learn how to use git then they probably don't know enough to contribute good code.
from waterfall.
GitHub is a git hosting site. It does not guarantee that contributing to a project will be the easiest thing in the world. It is easy enough to submit changes with this patch system. Obviously, a separate code base is easier for skids to hack, but a patch system makes it easy to merge upstream.
from waterfall.
I'd argue it's easier for everyone. It makes it easy to merge commits with Bungeecord. Once you have the environment setup, it's easy to submit changes. Learn how to use git before you start complaining.
from waterfall.
Contributing should be easy, this is the purpose of github.
from waterfall.
What "why"?
from waterfall.
Why patch based? What are the advantages?
from waterfall.
I think that if the project aims to be collaboration oriented clean source is better.
from waterfall.
Faster recompile, faster changes review
from waterfall.
Yeah but less people working on it.
from waterfall.
you can download jar from CI
from waterfall.
I'm talking about PRs
from waterfall.
There is rebuildPatches.sh script
from waterfall.
this is just an useless complexity
from waterfall.
join to our irc 😉
from waterfall.
nevermind, the project is yours... let it became like spigot (collaborative -110%)
from waterfall.
It's not for me, i know how the patches works, in my opinion in this way everyone who isn't a git expert is unable to contribute to the project.
from waterfall.
We agreed to switch to a patch based system because it allows us to easily see and manage the diff with upstream.
It also allows us to easily merge upstream (it got very complicated in the old system).
Once you know how to contribute, its easy, although we should add a guide #10.
Making a large contribution to waterfall already has a relatively high barrier of entry, and switching back to the old system won't make it that much easier.
We will not be switching back to the old system just to slightly reduce the learning curve for contributing small patches to the repo.
If have a serious concern, bring it up on IRC, but don't complain about it being to hard.
from waterfall.
Related Issues (20)
- A task raised an exception. Task: net.md_5.bungee.connection.InitialHandler$6$1@5c56a117 HOT 3
- The server you were previously on went down, you have been connected to a fallback server HOT 1
- 1.20.2 resource pack deleted when players switch between servers HOT 5
- FR: ProxyReady Event? HOT 1
- [BUG] Fallback Server not working. HOT 13
- [BUG] Could not decode packet HOT 4
- Failed to set channel option 'CONNECT_TIMEOUT_MILLIS' with value '-1' HOT 5
- Error dispatching event ServerKickEvent HOT 2
- Possible Exploit HOT 2
- Entity Rewrite - Settings get reset HOT 5
- Request update to 1.20.4 HOT 1
- Unable to make field int java.awt.Color.value accessible HOT 1
- HAProxy 2.0+ Proxy Protocol Spam - InitialHandler - NativeIoException: recvAddress(..) failed: Connection reset by peer
- io.netty.handler.codec.DecoderException: Failed to decode: No key value in MapLike[{action:"suggest_command"}] HOT 2
- What wrong with this ? HOT 3
- [Bug] About Proxy-Protocol HOT 2
- player.sendMessage() throws exception after calling player.disconnect()
- Mark this project as Public Archive because of EoL HOT 1
- Javadocs broken - again HOT 3
- How to fork waterfall? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from waterfall.