Why? about waterfall HOT 18 CLOSED

But, what is hard in patches? Just change project code, rebuildPatches.sh, git commit, git push

from waterfall.

They are completely able to contribute. If they don't want to learn how to use git then they probably don't know enough to contribute good code.

from waterfall.

GitHub is a git hosting site. It does not guarantee that contributing to a project will be the easiest thing in the world. It is easy enough to submit changes with this patch system. Obviously, a separate code base is easier for skids to hack, but a patch system makes it easy to merge upstream.

from waterfall.

I'd argue it's easier for everyone. It makes it easy to merge commits with Bungeecord. Once you have the environment setup, it's easy to submit changes. Learn how to use git before you start complaining.

from waterfall.

Contributing should be easy, this is the purpose of github.

from waterfall.

What "why"?

from waterfall.

Why patch based? What are the advantages?

from waterfall.

I think that if the project aims to be collaboration oriented clean source is better.

from waterfall.

Faster recompile, faster changes review

from waterfall.

Yeah but less people working on it.

from waterfall.

you can download jar from CI

from waterfall.

I'm talking about PRs

from waterfall.

There is rebuildPatches.sh script

from waterfall.

this is just an useless complexity

from waterfall.

join to our irc 😉

from waterfall.

nevermind, the project is yours... let it became like spigot (collaborative -110%)

from waterfall.

It's not for me, i know how the patches works, in my opinion in this way everyone who isn't a git expert is unable to contribute to the project.

from waterfall.

We agreed to switch to a patch based system because it allows us to easily see and manage the diff with upstream.
It also allows us to easily merge upstream (it got very complicated in the old system).
Once you know how to contribute, its easy, although we should add a guide #10.

Making a large contribution to waterfall already has a relatively high barrier of entry, and switching back to the old system won't make it that much easier.
We will not be switching back to the old system just to slightly reduce the learning curve for contributing small patches to the repo.

If have a serious concern, bring it up on IRC, but don't complain about it being to hard.

from waterfall.