in_place = true doesn't work in pre-commit about toml-sort HOT 4 CLOSED

@wwuck sorry, done!

from toml-sort.

Another easy way to fix would be to make a second pre-commit hook in .pre-commit-hooks.yaml called toml-sort-fix or toml-sort-in-place or something like that with a default args of --in-place rather than check.
That way no existing behavior needs to change.

from toml-sort.

Thanks for clearly laying out this issue!

I'm actually the opposite to you in that I almost always manually configure my hooks based on the locally-installed tooling. So, I don't really have a strong preference here as long as any resolution 1. doesn't negatively impact too many people, and 2. doesn't introduce too much complexity to the codebase.

Based on the above requirements, I have a slight preference for your suggestion to create additional hooks. Seems like it'll preserve backwards compatibility without introducing any unintended behavioral changes.

I'll happily consider a PR if you find time to create one!

from toml-sort.

@pappasam any chance of a new release tag on github for the new pre-commit hook? pre-commit requires the tag on github as a version reference so the new hook is inaccessible until then.

from toml-sort.