Giter VIP home page Giter VIP logo

Comments (5)

parautenbach avatar parautenbach commented on August 17, 2024

Certainly, I'll look at it ASAP.

Just as an extra: Which VCS are you using?

And, does your TeamCity username match the VCS username, or do you have a mapping set under your TeamCity user settings? (It looks like your using AD integration.) One way to know whether this mapping is working is to check whether your changes are highlighted like in the screen shot.
screen shot 2014-04-02 at 9 45 30 pm

The reason I'm asking is that I'm using the descriptive name (as opposed to just the name, which is optional to set in TeamCity, as you know), which will either return the full name or otherwise the username, but only if the username exists on TeamCity (according to Jetbrains when I asked them about this last time).

from teamcity-hipchat-notifier.

pawelpabich avatar pawelpabich commented on August 17, 2024

Thanks.

  1. TFS
  2. My username and VCS username are different. My username is pawel.pabich and my VCS user name is company\pawel.pabich.
  3. Under TC I have username, name and email address specified. I would say this mapping does not work as TC displays company\pawel.pabich. Attached screenshot of my user settings.
    user

Let me know if you need anything else. I have TC setup locally so I can test fixes relatively quickly.

from teamcity-hipchat-notifier.

parautenbach avatar parautenbach commented on August 17, 2024

Ok, thanks. I think we're onto something.

Perhaps change your default VCS root username (as per your screen shot)? Alternatively, add company\pawel.pabich as a mapping for TFS.

Could your server admin also check whether a default domain is configured for your auth scheme (on TeamCity)?

When we can get TeamCity to correctly identify the VCS commit as being yours, I'm 99% certain the plugin will then work correctly too.

I could revert to my previous implementation, but I already knew then that it was just a hack (it will fail in other ways). I could potentially retrieve the user-to-VCS mapping and apply it myself, but that's kind of what the getCommitters call is supposed to do.

from teamcity-hipchat-notifier.

pawelpabich avatar pawelpabich commented on August 17, 2024

I change my VCS name to company\pawel.pabich and now it works. Thanks a lot

from teamcity-hipchat-notifier.

parautenbach avatar parautenbach commented on August 17, 2024

Excellent, that's good news. You're welcome.

from teamcity-hipchat-notifier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.