Comments (3)
thomaseizinger
commented on August 18, 2024
1
The real issue in our case was because fixed-hash is transitive dependency! So I don't get to choose which version I get but we do still use the (re-exported) types from that crate. Meaning I have a compiler warning that I can't fix :D
It is not too bad because I was able to avoid the dependency upgrade for now but I think in general, you should only deprecate a method if you also provide a solution in the same(!) version. E.g.: you deprecate something in 2.5, that version should have the alternative method, not the next one because you are not always in control over which version you get.
from parity-common.
dvdplm
commented on August 18, 2024
not adding the suggested method at the same time?
But version 0.3 is out! The reasoning was that we wanted people to upgrade, but I hear you, we probably should have added the methods to a 0.2.6 where possible. Will keep it in mind for the future.
from parity-common.
Robbepop
commented on August 18, 2024
Ah that is a truly bad miscommunication!
Very sorry for that. Next time we communicate this intent better.
from parity-common.
Related Issues (20)
- U256 type does not support `num_traits::int::PrimInt` HOT 3
- Could we have a new crates release for primitive-types please? HOT 1
- [rlp] `RlpIterator::len()` does not update when the iterator is consumed. HOT 1
- From<i64> impl is invalid HOT 2
- ethereum-types: Consider depending on uint v0.9.4 or above
- rlp: handling extra data HOT 1
- rlp: list length and contents are not validated
- Where is patricia-trie? HOT 1
- Implement BoundedVec with bound on both end HOT 2
- Implement `Serialize / Deserialize` for `BoundedBtreeSet` HOT 3
- Implement BoundedVec::try_with_capacity
- Is it possible to use unit in no_std projects? HOT 1
- Is there a corresponding library in Go for Rust's primitive-types package? HOT 1
- num-traits feature on primitive-types could use a FromPrimitive impl
- [uint] conversion between uint types HOT 2
- rlp - test failures on 32-bit HOT 1
- Missing I256 HOT 2
- fixed-hash: allow opting out `rand` when `std` enabled
- uint bench doesn't compile anymore?
- Default RocksDB WAL log size settings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from parity-common.