RPC methods meta issue about parity-zcash HOT 4 CLOSED

Yes should be able to support multiple optional args with jsonrpc-derive, see here. Just need to fill in the missing ones with None.

from parity-zcash.

@svyatonik jsonrpc-derive is now merged, I've added an issue paritytech/jsonrpc#363 to implement multiple trailing params. I'm happy to do the work to rebase your branch - just let me know.

By the way the issue with failing to deserialize single tuple was because of a missing comma. Single param tuple should be (u64,).

from parity-zcash.

This is currently blocked by the fact that currently jsonrpc_macro doesn't support more than one optional Trailing argument && we need more in some RPC methods (createrawtransaction is the first example). So we need either to support this case in jsonrpc (preferable) or to do a custom args parsing in pzec.

I was researching if that's easy-to-add-feature to the existing jsonrpc_macro && looks like it is, but the problem is that it would require custom macro of ~150 LOCs for every number of trailing args that we're going to support (i.e. if there'll be RPC with 6 optional trailing args, we'll need ~1KLOC), which isn't ideal. Moreover, today I stumbled upon this PR, which should obsolete jsonrpc_macro. So I'm currently researching if this is easy/possible to support multiple optional args in jsonrpc-derive. If so, then we'll probably switch to custom jsonrpc branch until new version is merged && published.

from parity-zcash.

@ascjones Thanks! I'll open PR a bit later && will cc you :)

from parity-zcash.