Possibility to add Query params in form of struct. about gorequest HOT 8 CLOSED

Hi Warik!

That would be very good idea. I am always welcome for pull request.
You can mimic the implementation of Send, SendStruct and SendString as well as some testing on these function.

Although, testing part of Gorequest is still in progress, you should make some amount of testing that showing your new implementation does not break other part. I will work with you on the test if you need help.

from gorequest.

Hi @warik,

Just want to follow up with the issue. What do you think? ;)

from gorequest.

Hi @parnurzeal. Yes, exactly what i wanted to do. Thanks for Your detailed comment, I'll do what we decided as soon as i'll be up and running again. Currently having some issues with health.

from gorequest.

Hi @warik,
Sorry to hear that and hope you get well soon!
If you need any help on testing or other parts, feel free to ask anytime!

Thanks!

from gorequest.

Hi @warik, how are you?
Wanna give it a try? Pull request is still welcome ;)

from gorequest.

I have done this in the features/add_query_from_structures branch of my fork of your repo github.com/figlief/gorequest

The problem is only capital first letters are allowed! for now I lower case the keys. Other alternatives?

I have done a simple cut and paste job, the common code should be factored out really.

I have refactored the relavent bit of test code as the tests crash if the key is not found! very confusing and unhepfull.

Will do more work if you approve.

This is my first ever pull request , sorry If I screw it up.

from gorequest.

For now, it works. If we find more issue, let's fix it.
Thanks for your contribution. ;)

from gorequest.

Was this every actually implemented?

from gorequest.