Comments (8)
Hi Warik!
That would be very good idea. I am always welcome for pull request.
You can mimic the implementation of Send, SendStruct and SendString as well as some testing on these function.
Although, testing part of Gorequest is still in progress, you should make some amount of testing that showing your new implementation does not break other part. I will work with you on the test if you need help.
from gorequest.
Hi @warik,
Just want to follow up with the issue. What do you think? ;)
from gorequest.
Hi @parnurzeal. Yes, exactly what i wanted to do. Thanks for Your detailed comment, I'll do what we decided as soon as i'll be up and running again. Currently having some issues with health.
from gorequest.
Hi @warik,
Sorry to hear that and hope you get well soon!
If you need any help on testing or other parts, feel free to ask anytime!
Thanks!
from gorequest.
Hi @warik, how are you?
Wanna give it a try? Pull request is still welcome ;)
from gorequest.
I have done this in the features/add_query_from_structures branch of my fork of your repo github.com/figlief/gorequest
The problem is only capital first letters are allowed! for now I lower case the keys. Other alternatives?
I have done a simple cut and paste job, the common code should be factored out really.
I have refactored the relavent bit of test code as the tests crash if the key is not found! very confusing and unhepfull.
Will do more work if you approve.
This is my first ever pull request , sorry If I screw it up.
from gorequest.
For now, it works. If we find more issue, let's fix it.
Thanks for your contribution. ;)
from gorequest.
Was this every actually implemented?
from gorequest.
Related Issues (20)
- query with int64 will lose accuracy HOT 1
- Callback for upload progress HOT 1
- Keys of query params are incorrectly converted to lower case when in form of map. HOT 2
- Retry implementation is wrong
- How to use context in gorequest? HOT 3
- The return data is too large, an error occurs, and the return is nil
- can't set http header or send request body HOT 1
- Get request frequently get unexpected EOF error
- unexpected end of JSON input in req.EndStruct(body)
- http_proxy env support HOT 1
- dkron stops running job for no apparen reason
- support for go modules
- can't send body "{}" HOT 1
- Retry with self-defined http response status code HOT 2
- Suggestion: Change the deranged Gopher machine gun image :-p
- why this package always reordering alphabetical query parameter or body json? i need disabled it
- 大佬你还更新吗 HOT 3
- send string json ,It will be serialized automatically
- session.post
- A convenient suggestion on gorequest HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gorequest.