don't ignore `min_coverage` in `mix coveralls.json` about excoveralls HOT 4 OPEN

@parroty couldn't find any reports here but the same thing happens with coveralls.github the min coverage is just ignored.

from excoveralls.

Thank you for the comment 🙇 . I am now checking this item through #305.

from excoveralls.

Thank you for the feedback 🙇 . I assume it's related to #286.

While it may make sense to have that feature for mix coveralls.json, my concern is that it can become a breaking change. If it can be taken as optional feature, it might be good to add that capability, though.

from excoveralls.

+1 for not ignoring minimum_coverage when running mix coveralls.github too

I'm currently seeing this situation on GitHub Actions:

coverage/coveralls Expected — Waiting for status to be reported

Even though coverage is visible on their website:

Successfully uploaded the report to 'https://coveralls.io/'

To work around that (for now), I could disable the branch requirement for coverage/coveralls. But it would be nice if the coveralls.json minimum_coverage setting would act as a fallback in that situation, so we still fail CI if coverage falls too much.

from excoveralls.