Giter VIP home page Giter VIP logo

Comments (4)

cswank avatar cswank commented on May 29, 2024

@adranwit I just opened a PR for this, but the gzip unit tests are very slow, so I'd like to find out why before merging.

#13

from parquet.

cswank avatar cswank commented on May 29, 2024

Oh wow, you made some huge changes in your fork, I'd be interested to hear how that fork is working out.

from parquet.

adranwit avatar adranwit commented on May 29, 2024

Thanks, for picking up PR, like your initial approach, (low memory consumption and reasonable speed)
We're using parquet to load data to BQ,
sadly the original library has issues and is incompatible with Parque spec (version 1), and nested repeated fields do not work in 2 levels down.

I this point I got it working to load data to BQ, reading code generation still has some issue.

I haven't heard from you for some time, so I've rewritten code generation, and patched various issue,
I plan to rewrite it at some, point from "scratch", leaving some abstraction, adding more features like a dictionary.

https://github.com/viant/parquet

from parquet.

cswank avatar cswank commented on May 29, 2024

I'm not surprised that our lib has issues like you found, since I started with zero parquet knowledge when I worked on this. Parquet has so many options and I found it really hard to get everything right.

It is working fine for our use case (no nesting in AWS Glue) so we rarely have had to touch it since I wrote it 2 years ago.

Anyhow, your fork is obviously way out of sync with our version, but I'd be interested in some kind of collaboration. I'd even consider adapting the work you've done in your fork since you've been able to fix some issues with our version. One thing I'm kind of surprised about, though, is that your fork dropped the unit tests at the root of the repo. I found those absolutely invaluable. They are how I was able to get gzip working in just one morning. I made the same mistake your fork did (not reading CompressedPageSize into the gzip reader) and the tests helped me find that.

Also, I've been wanting to try my hand at dictionary encoding for a while, but I have been unable to figure out how that works. The documentation is sparse and all the other implementations are really hard to read.

Anyhow, I'd be totally down for merging your work into our repo if it is more correct than our version.

from parquet.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.