Make disabling interrupts optional about brzo_i2c HOT 4 CLOSED

Glad to hear that brzo_i2c is useful for you 😄

Yes, this sounds reasonable. Actually, I thought of such an option, too. But due to lack of time I did not change it yet. I agree that having this option "globally" is enough, i.e. we don't need to pass it to each brzo_i2c_write / read as optional parameters.

Well, since you asked that nicely: If you are able to do a pull request, it is very welcome!

from brzo_i2c.

@pasko-zh I'll open a PR as soon as I have time to finish it.

Do you think a #define statement in the header would suffice? Or should it still be allowed to set that at runtime via e.g. a function brzo_i2c_set_disable_interrupts?

from brzo_i2c.

I think it is enough with a #define. Otherwise, one should think of enable/disable the interrupts for each write/read or to move it on the level of an i2c transaction, i.e. pass it through an additional paramter.
But I think this fine grained enbaling/disabling is not really a need, right?

from brzo_i2c.

@pasko-zh At least not for my use case. I suppose a #define is enough for now.

from brzo_i2c.