Comments (3)
Had the same kind of problem with 'f' being accepted in base 15.
In theory we should only be able to go up to 'e' (being 14 in base 10). The code does 'e' and '10' correctly, showing 14 and 15 respectively, the problem is, it also shows 15 for 'f'.
When going through the code at first, I noticed something strange with base 16. The 'else if' condition in line 17 excluded 'g' as a character although the 'c <= max_digit' would have included it.
Everything else seems OKAY! I'm still fairly new to 42 and coding in general so please bear with me ^^
Also, thank you for your github! I don't know what I'd do with out it . You're a REAL G :) :)
from 42-school-exam-rank-02.
create a pull request and I'll accept the request.
from 42-school-exam-rank-02.
create a pull request and I'll update it. Thanks!
from 42-school-exam-rank-02.
Related Issues (16)
- fprime fprime doesn't compile
- putstr has extra r in char
- Exam Rank 02 - pgcd.c HOT 1
- ft_rrange.c HOT 2
- forbidden function in ft_split HOT 1
- Diffrent type cast in function HOT 2
- ft_range HOT 1
- Else condition after while HOT 3
- wrong solution rostring level4 examrank02 HOT 1
- Wont pass official exam (rank 2) ft_atoi_base
- Enhancing FizzBuzz Program HOT 1
- rosting doesnt work with ./a.out "abc def " HOT 2
- add_prime_sum not handeling case with no extra args
- tab_mult handeling negative numbers
- ft_range
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 42-school-exam-rank-02.