Giter VIP home page Giter VIP logo

Comments (3)

C42joseri avatar C42joseri commented on July 20, 2024 2

Had the same kind of problem with 'f' being accepted in base 15.
In theory we should only be able to go up to 'e' (being 14 in base 10). The code does 'e' and '10' correctly, showing 14 and 15 respectively, the problem is, it also shows 15 for 'f'.
When going through the code at first, I noticed something strange with base 16. The 'else if' condition in line 17 excluded 'g' as a character although the 'c <= max_digit' would have included it.
Everything else seems OKAY! I'm still fairly new to 42 and coding in general so please bear with me ^^
Also, thank you for your github! I don't know what I'd do with out it . You're a REAL G :) :)

from 42-school-exam-rank-02.

pasqualerossi avatar pasqualerossi commented on July 20, 2024

create a pull request and I'll accept the request.

from 42-school-exam-rank-02.

pasqualerossi avatar pasqualerossi commented on July 20, 2024

create a pull request and I'll update it. Thanks!

from 42-school-exam-rank-02.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.