Giter VIP home page Giter VIP logo

Comments (19)

drmoose avatar drmoose commented on May 25, 2024 1

Aha:

$ PASSWORD_STORE_DIR=/nowhere pass ls /
Error: / is not in the password store.

Sorry again about the bad info above.

from passff.

tuxor1337 avatar tuxor1337 commented on May 25, 2024

I have no clue. So, the list of your entries shows up correctly in the PassFF pop-up menu, but when you select some entry and select any "display" or "copy to clipboard" or "fill" action, it will do nothing? Which version of pass do you use?

from passff.

rixx avatar rixx commented on May 25, 2024

No, the pop-up menu doesn't show anything, either. I cannot get any part of passff to work – the working part is calling the passff.py manually.

I'm running pass v1.7.4.

from passff.

tuxor1337 avatar tuxor1337 commented on May 25, 2024

Why do you think that this is related to not picking up the PASSWORD_STORE_DIR variable? If the variable is not set, pass should show the following output:

$ PASSWORD_STORE_DIR="" pass 
Error: password store is empty. Try "pass init".

I have no idea how you would willingly produce the output / is not in the password store.

from passff.

drmoose avatar drmoose commented on May 25, 2024

@tuxor1337 I've run into this before. Passff says / is not in the password store when $PASSWORD_STORE_DIR points to an extant, but empty, folder.

$ PASSWORD_STORE_DIR="$(mktemp -d)" pass
Password Store

Sadly I don't know how to solve @rixx problem for real, as I haven't been able to get environment variables to pass through Firefox either. My workaround was to just ln -sT ~/.local/share/password-store ~/.password-store.

from passff.

tuxor1337 avatar tuxor1337 commented on May 25, 2024

You can set environment variables in your passff.py host script. But this should only be a last resort. Usually, it's supposed to use the same environment where Firefox lives.

@drmoose I don't understand your comment about the / is not in the password store output because it obviously isn't reproduced by the commandline that you quote.

from passff.

drmoose avatar drmoose commented on May 25, 2024

/ is not in the password store is an error message from passff, rather than pass. But it turns out I was wrong and it's "nonexistant folder" rather than "empty folder" (sorry; misremembered).

image

I have no idea how to get this error message from pass itself. In this condition pass shows the "store is empty" error in your example.

from passff.

tuxor1337 avatar tuxor1337 commented on May 25, 2024

Okay, thanks for double-checking!

@rixx Then please try to manually set the correct PASSWORD_STORE_DIR in the COMMAND_ENV dict in your passff.py and see whether this will at least work around this issue.

from passff.

rixx avatar rixx commented on May 25, 2024

That did it, perfect, thank you!

from passff.

xeruf avatar xeruf commented on May 25, 2024

Please reopen this, as this issue has bugged me for months! An available workaround is not a fix. Thank You :)

from passff.

xeruf avatar xeruf commented on May 25, 2024

I guess the fix should be added into https://github.com/passff/passff-host/blob/main/src/passff.py

from passff.

xeruf avatar xeruf commented on May 25, 2024

Interestingly enough, I only have this issue on Manjaro Sway (Wayland), not on my Arch+KDE machines...

from passff.

xeruf avatar xeruf commented on May 25, 2024

And don't forget to include o+rx rights on the PASSWORD_STORE_DIR - or is there a group I may use for more precise permissions?

from passff.

tuxor1337 avatar tuxor1337 commented on May 25, 2024

I don't think there is anything we can do on our side. If the PASSWORD_STORE_DIR environment variable isn't set or is set to a wrong value, there is no way that we can decide whether this is intentional or not. We already do the best we can by forwarding the pass error message.

from passff.

xeruf avatar xeruf commented on May 25, 2024

well, but is there no way to pass the PASSWORD_STORE_DIR from the environment on to the script automatically?

from passff.

tuxor1337 avatar tuxor1337 commented on May 25, 2024

If the variable is set (and to the right value) in the environment where the script is executed, then the script will work as intended. If the variable isn't set (or to the wrong value), then there is nothing that the script can do about it.

Please note that this "just works" for most users. And I have no clue why it doesn't work for you and the OP. Somehow you are working with a setup where the host script gets executed in an environment where the PASSWORD_STORE_DIR variable is not set or is set to the wrong value.

from passff.

nsailor avatar nsailor commented on May 25, 2024

Hi, I think I'm having the same issue. Modifying passff.py works.
Interestingly, I'm also running Sway on Arch, something strange is going on here.

from passff.

nsailor avatar nsailor commented on May 25, 2024

@xeruf After a bit of troubleshooting, I was able to figure out what was going on on my system.

I am using fish, and was setting the PASSWORD_STORE_DIR environment variable in my .config/fish/config.fish file. However, I was launching sway from a login manager (greetd), and therefore the environment variables where not available to sway.

As a result, when starting Firefox from a terminal passff worked fine, but when starting it with sway exec firefox I would get / is not in the password store. The obvious fix is to set any needed environment variables in ~/.profile.

No issue to fix with passff at all.

from passff.

tuxor1337 avatar tuxor1337 commented on May 25, 2024

@nsailor Thanks a lot for the investigation! 🙏

from passff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.