Comments (5)
You are 100% correct, didn't think of that. See it's just looking for all titles in the HTML which is not right at https://github.com/passmarked/seo/blob/develop/lib/rules/title.js#L77.
Easy fix is probably to just check the head or just check if the parent, thoughts? Would be interested in beefing this up a bit more if you know of any more scenarios?
from seo.
Permitted parents
A<head>
element that contains no other<title>
element.
So checking if it’s inside a <head>
element and is unique is enough?
from seo.
@gnclmorais yes think you are on the money, will update to just look under <head>
. Expect a PR in a few.
from seo.
I guess this will also affect title.location
too, thinking about it
from seo.
Thanks for the report, catching up on my workload now only. See #23 for the PR, will merge once tests pass
from seo.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.